Conversation
achingbrain
left a comment
There was a problem hiding this comment.
Can these metrics please get added to the built in libp2p metrics object instead of being their own thing?
|
The approach of Note gossipsub rolls its own metrics system too https://github.com/ChainSafe/js-libp2p-gossipsub/blob/master/src/metrics.ts |
|
Updated PR to use a "metrics generator" so that consumer only needs to pass something that can create Gauge instances. This follows similar encapsulation principles as built in libp2p metrics object but with no performance penalty. |
87509da to
f0153b7
Compare
|
superseeded by #246 |
Minimal set of metrics to track errors and measure packet rate