Fixed: Allow Listening to Subscription Errors#8384
Merged
michaelstaib merged 2 commits intoJun 25, 2025
Merged
Conversation
Member
|
@7rakir can you sign the CLA so we can merge your change? |
Contributor
Author
I might be doing something wrong, but:
I've clicked the "recheck" link in the CLAassistant comment. |
Member
|
@7rakir you are probably using different email addresses |
Contributor
Author
Correct as usual. Thank you. Should be OK now. |
michaelstaib
approved these changes
Jun 25, 2025
This was referenced Jul 29, 2025
This was referenced Aug 18, 2025
This was referenced Aug 25, 2025
This was referenced Jun 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
There are two overloaded methods for
ExecutionDiagnosticEventListener.SubscriptionEventError.One called with
payloadinSubscription.OnEvent; the other when enumerating subscriptions inSubscriptionEnumerableandSubscriptionEnumerator.Users can override the former when deriving from
ExecutionDiagnosticEventListener, but cannot override the latter.If an exception happens during subscribing,
AggregateExecutionDiagnosticEventscallsSubscriptionEventError(ISubscription, Exception). No listener deriving fromExecutionDiagnosticEventListenercannot override this and the call results in no-op.Notes
I'm making only this small change for v15, because I understand
ExecutionDiagnosticEventListeneris being refactored for v16.Tests
I haven't found any relevant tests for this particular functionality, but if they exist, please point them out to me.