Skip to content

Fixed: Allow Listening to Subscription Errors#8384

Merged
michaelstaib merged 2 commits into
ChilliCream:main-version-15from
7rakir:bugfix/no-op-subscription-event-error
Jun 25, 2025
Merged

Fixed: Allow Listening to Subscription Errors#8384
michaelstaib merged 2 commits into
ChilliCream:main-version-15from
7rakir:bugfix/no-op-subscription-event-error

Conversation

@7rakir

@7rakir 7rakir commented Jun 25, 2025

Copy link
Copy Markdown
Contributor

Context
There are two overloaded methods for ExecutionDiagnosticEventListener.SubscriptionEventError.
One called with payload in Subscription.OnEvent; the other when enumerating subscriptions in SubscriptionEnumerable and SubscriptionEnumerator.

Users can override the former when deriving from ExecutionDiagnosticEventListener, but cannot override the latter.
If an exception happens during subscribing, AggregateExecutionDiagnosticEvents calls SubscriptionEventError(ISubscription, Exception). No listener deriving from ExecutionDiagnosticEventListener cannot override this and the call results in no-op.

Notes
I'm making only this small change for v15, because I understand ExecutionDiagnosticEventListener is being refactored for v16.

Tests
I haven't found any relevant tests for this particular functionality, but if they exist, please point them out to me.

@CLAassistant

CLAassistant commented Jun 25, 2025

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@michaelstaib

Copy link
Copy Markdown
Member

@7rakir can you sign the CLA so we can merge your change?

@7rakir

7rakir commented Jun 25, 2025

Copy link
Copy Markdown
Contributor Author

@7rakir can you sign the CLA so we can merge your change?

I might be doing something wrong, but:

I've clicked the "recheck" link in the CLAassistant comment.
I've revoked the CLA from the last year now and re-signed again, just to be sure. I guess it takes some time to propagate.

@michaelstaib

Copy link
Copy Markdown
Member

@7rakir you are probably using different email addresses

@7rakir

7rakir commented Jun 25, 2025

Copy link
Copy Markdown
Contributor Author

@7rakir you are probably using different email addresses

Correct as usual. Thank you. Should be OK now.

@michaelstaib michaelstaib changed the title Allow listening to failed Subscription Fixed: Allow Listening to Subscription Errors Jun 25, 2025
@michaelstaib michaelstaib merged commit 4cbc751 into ChilliCream:main-version-15 Jun 25, 2025
5 checks passed
@michaelstaib michaelstaib added this to the HC-15.1.7 milestone Jun 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants