Add OperationRequestBuilder.AddFile#9730
Merged
Merged
Conversation
tobias-tengler
force-pushed
the
tte/hotchocolate-testing
branch
from
dbb044e to
fd31d92
Compare
tobias-tengler
changed the title
github-actions
Bot
added
the
📚 documentation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR introduces a first-class way to associate uploaded files with an OperationRequestBuilder so Upload variables can be resolved via the IFileLookup feature, and updates docs/tests accordingly.
Changes:
- Added
OperationRequestBuilderExtensions.AddFile(string name, IFile file)to register files on an operation request via an internalIFileLookupimplementation. - Added
OperationRequestFileLookupas the internal, mutableIFileLookupused byAddFile. - Updated the v15→v16 migration guide to recommend
AddFileinstead of manually wiringIFileLookup, and added unit tests for the new API.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| website/src/docs/hotchocolate/v16/migrating/migrate-from-15-to-16.md | Updates migration guidance to use AddFile for Upload variables and removes the manual IFileLookup example. |
| src/HotChocolate/Core/test/Execution.Abstractions.Tests/Execution/OperationRequestBuilderExtensionsTests.cs | Adds unit tests covering AddFile registration and argument validation behavior. |
| src/HotChocolate/Core/src/Execution.Abstractions/Execution/OperationRequestFileLookup.cs | Introduces internal IFileLookup implementation to store files by key. |
| src/HotChocolate/Core/src/Execution.Abstractions/Execution/Extensions/OperationRequestBuilderExtensions.cs | Adds the AddFile extension method and wires it to the features collection. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This was referenced Jun 1, 2026
This was referenced Jun 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.