Skip to content

Commit 2ae8f26

Browse files
ThomasQuesadillaDevtools-frontend LUCI CQ
authored andcommitted
Removes PermissionPolicyNotDelegated issue handling from DevTools
As per WICG/attribution-reporting-api#713, this issue is no longer needed. The browser protocol references are modified in the followup CL due to repo regulations. Bug:1420676 Change-Id: I7110c61331e7faa57722775a91d584cac41c8479 Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/4307434 Reviewed-by: Simon Zünd <szuend@chromium.org> Reviewed-by: Andrew Paseltiner <apaseltiner@chromium.org> Commit-Queue: Andrew Paseltiner <apaseltiner@chromium.org>
1 parent c5ad7da commit 2ae8f26

5 files changed

Lines changed: 0 additions & 25 deletions

File tree

config/gni/devtools_grd_files.gni

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -293,7 +293,6 @@ grd_files_release_sources = [
293293
"front_end/models/issues_manager/descriptions/arInvalidRegisterSourceHeader.md",
294294
"front_end/models/issues_manager/descriptions/arInvalidRegisterTriggerHeader.md",
295295
"front_end/models/issues_manager/descriptions/arPermissionPolicyDisabled.md",
296-
"front_end/models/issues_manager/descriptions/arPermissionPolicyNotDelegated.md",
297296
"front_end/models/issues_manager/descriptions/arSourceAndTriggerHeaders.md",
298297
"front_end/models/issues_manager/descriptions/arSourceIgnored.md",
299298
"front_end/models/issues_manager/descriptions/arTriggerIgnored.md",

front_end/models/issues_manager/AttributionReportingIssue.ts

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@ import {type MarkdownIssueDescription} from './MarkdownIssueDescription.js';
1010

1111
export const enum IssueCode {
1212
PermissionPolicyDisabled = 'AttributionReportingIssue::PermissionPolicyDisabled',
13-
PermissionPolicyNotDelegated = 'AttributionReportingIssue::PermissionPolicyNotDelegated',
1413
UntrustworthyReportingOrigin = 'AttributionReportingIssue::UntrustworthyReportingOrigin',
1514
InsecureContext = 'AttributionReportingIssue::InsecureContext',
1615
InvalidRegisterSourceHeader = 'AttributionReportingIssue::InvalidRegisterSourceHeader',
@@ -29,8 +28,6 @@ function getIssueCode(details: Protocol.Audits.AttributionReportingIssueDetails)
2928
switch (details.violationType) {
3029
case Protocol.Audits.AttributionReportingIssueType.PermissionPolicyDisabled:
3130
return IssueCode.PermissionPolicyDisabled;
32-
case Protocol.Audits.AttributionReportingIssueType.PermissionPolicyNotDelegated:
33-
return IssueCode.PermissionPolicyNotDelegated;
3431
case Protocol.Audits.AttributionReportingIssueType.UntrustworthyReportingOrigin:
3532
return IssueCode.UntrustworthyReportingOrigin;
3633
case Protocol.Audits.AttributionReportingIssueType.InsecureContext:
@@ -93,11 +90,6 @@ export class AttributionReportingIssue extends Issue<IssueCode> {
9390
file: 'arPermissionPolicyDisabled.md',
9491
links: [],
9592
};
96-
case IssueCode.PermissionPolicyNotDelegated:
97-
return {
98-
file: 'arPermissionPolicyNotDelegated.md',
99-
links: [],
100-
};
10193
case IssueCode.UntrustworthyReportingOrigin:
10294
return {
10395
file: 'arUntrustworthyReportingOrigin.md',
@@ -157,8 +149,6 @@ export class AttributionReportingIssue extends Issue<IssueCode> {
157149

158150
getKind(): IssueKind {
159151
switch (this.code()) {
160-
case IssueCode.PermissionPolicyNotDelegated:
161-
return IssueKind.BreakingChange;
162152
case IssueCode.PermissionPolicyDisabled:
163153
case IssueCode.UntrustworthyReportingOrigin:
164154
case IssueCode.InsecureContext:

front_end/models/issues_manager/BUILD.gn

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,6 @@ devtools_issue_description_files = [
5858
"arInvalidRegisterSourceHeader.md",
5959
"arInvalidRegisterTriggerHeader.md",
6060
"arPermissionPolicyDisabled.md",
61-
"arPermissionPolicyNotDelegated.md",
6261
"arSourceAndTriggerHeaders.md",
6362
"arSourceIgnored.md",
6463
"arTriggerIgnored.md",

front_end/models/issues_manager/descriptions/arPermissionPolicyNotDelegated.md

Lines changed: 0 additions & 11 deletions
This file was deleted.

front_end/panels/issues/AttributionReportingIssueDetailsView.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,6 @@ export class AttributionReportingIssueDetailsView extends AffectedResourcesView
7474
this.appendColumnTitle(header, i18nString(UIStrings.untrustworthyOrigin));
7575
break;
7676
case IssuesManager.AttributionReportingIssue.IssueCode.PermissionPolicyDisabled:
77-
case IssuesManager.AttributionReportingIssue.IssueCode.PermissionPolicyNotDelegated:
7877
this.appendColumnTitle(header, i18nString(UIStrings.element));
7978
this.appendColumnTitle(header, i18nString(UIStrings.request));
8079
break;
@@ -120,7 +119,6 @@ export class AttributionReportingIssueDetailsView extends AffectedResourcesView
120119
this.appendIssueDetailCell(element, details.invalidParameter || '');
121120
break;
122121
case IssuesManager.AttributionReportingIssue.IssueCode.PermissionPolicyDisabled:
123-
case IssuesManager.AttributionReportingIssue.IssueCode.PermissionPolicyNotDelegated:
124122
await this.#appendElementOrEmptyCell(element, issue);
125123
this.#appendRequestOrEmptyCell(element, details.request);
126124
break;

0 commit comments

Comments
 (0)