Update default permission policy#713
Merged
csharrison merged 2 commits intomainfrom Mar 1, 2023
Merged
Conversation
apasel422
reviewed
Mar 1, 2023
apasel422
approved these changes
Mar 1, 2023
aarongable
pushed a commit
to chromium/chromium
that referenced
this pull request
Mar 2, 2023
As per WICG/attribution-reporting-api#713, this warning is no longer needed. Will remove enum value once its corresponding devtool value is removed. Bug: 1420671 Change-Id: Ib7b626c603784906cf4122691b6caba337d81644 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4299641 Reviewed-by: Andrew Paseltiner <apaseltiner@chromium.org> Reviewed-by: Charlie Harrison <csharrison@chromium.org> Commit-Queue: Andrew Paseltiner <apaseltiner@chromium.org> Reviewed-by: Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/main@{#1112187}
copybara-service Bot
pushed a commit
to ChromeDevTools/devtools-frontend
that referenced
this pull request
Mar 6, 2023
As per WICG/attribution-reporting-api#713, this issue is no longer needed. The browser protocol references are modified in the followup CL due to repo regulations. Bug:1420676 Change-Id: I7110c61331e7faa57722775a91d584cac41c8479 Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/4307434 Reviewed-by: Simon Zünd <szuend@chromium.org> Reviewed-by: Andrew Paseltiner <apaseltiner@chromium.org> Commit-Queue: Andrew Paseltiner <apaseltiner@chromium.org>
aarongable
pushed a commit
to chromium/chromium
that referenced
this pull request
Mar 7, 2023
As per WICG/attribution-reporting-api#713, this issue is no longer needed. This should be submitted after https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/4307434 Bug: 1420676 Change-Id: Ie21be1650552aea6756d8c17d053bb2f1d7fd97a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4307553 Quick-Run: Andrew Paseltiner <apaseltiner@chromium.org> Reviewed-by: Nate Chapin <japhet@chromium.org> Reviewed-by: Andrew Paseltiner <apaseltiner@chromium.org> Commit-Queue: Andrew Paseltiner <apaseltiner@chromium.org> Cr-Commit-Position: refs/heads/main@{#1113907}
This comment was marked as spam.
This comment was marked as spam.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #558
Preview | Diff