Conversation
JalexChen
left a comment
There was a problem hiding this comment.
don't think i see anything glaringly wrong, but i think what would be helpful is to include a comment in the PR with detailed and bulleted notes on what is going on or this could probably be done with smaller PRs too, but i've worked on this before so i know how massive it is and how many touchpoints there are.
i do like the executor refactoring though
Since this touches a core component, it made it essential to make these changes at once to not break the codebase. Outside of some of the refactoring stuff that I couldn't help myself to ignore 😛 There's actually a little bit more to be done here, (for steps specifically) but they will be included in their own PR next. Thanks for the feedback! |
No description provided.