Skip to content
This repository was archived by the owner on Jun 13, 2024. It is now read-only.

Chore: upgraded to newest sdk alpha#95

Merged
Jaryt merged 3 commits intomainfrom
chore/sdk-alpha-14
May 31, 2022
Merged

Chore: upgraded to newest sdk alpha#95
Jaryt merged 3 commits intomainfrom
chore/sdk-alpha-14

Conversation

@Jaryt
Copy link
Copy Markdown
Contributor

@Jaryt Jaryt commented May 20, 2022

No description provided.

@Jaryt Jaryt changed the title chore: upgraded to newest sdk alpha Chore: upgraded to newest sdk alpha May 20, 2022
@Jaryt Jaryt requested review from FelicianoTech and KyleTryon May 31, 2022 22:06
Copy link
Copy Markdown

@JalexChen JalexChen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't think i see anything glaringly wrong, but i think what would be helpful is to include a comment in the PR with detailed and bulleted notes on what is going on or this could probably be done with smaller PRs too, but i've worked on this before so i know how massive it is and how many touchpoints there are.

i do like the executor refactoring though

@Jaryt
Copy link
Copy Markdown
Contributor Author

Jaryt commented May 31, 2022

don't think i see anything glaringly wrong, but i think what would be helpful is to include a comment in the PR with detailed and bulleted notes on what is going on or this could probably be done with smaller PRs too, but i've worked on this before so i know how massive it is and how many touchpoints there are.

i do like the executor refactoring though

Since this touches a core component, it made it essential to make these changes at once to not break the codebase. Outside of some of the refactoring stuff that I couldn't help myself to ignore 😛

There's actually a little bit more to be done here, (for steps specifically) but they will be included in their own PR next. Thanks for the feedback!

@Jaryt Jaryt merged commit 006382d into main May 31, 2022
@Jaryt Jaryt deleted the chore/sdk-alpha-14 branch June 14, 2022 01:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants