fix: unselect selected comment on scroll#15463
Conversation
0046885 to
4126ab9
Compare
4126ab9 to
d17e06e
Compare
|
is this related to the changes? |
probably, let me check. |
Signed-off-by: Sahil Gautam <sahil.gautam@collabora.com> Change-Id: I617603782260d4c3c19e8bdeafc794e3b7457d1d
When scrolling, the selected comment should get unselected. Signed-off-by: Sahil Gautam <sahil.gautam@collabora.com> Change-Id: Id2c290fc67856c80cc5d9c359885ead3090fee6c
d17e06e to
d3c6928
Compare
|
the cypress test doesn't fail locally on latest main, so rebased the PR to see if it passes on the CI, if not, i will see what's wrong. |
Signed-off-by: Sahil Gautam <sahil.gautam@collabora.com> Change-Id: I77d46bf7669b9ae81df8ced13092c3dd0b612445
d3c6928 to
eaf925a
Compare
|
weird multi-page behavior: maybe we could implement the method for it too? |
|
it is more complicated
|
can we do that in a followup? would be good to have this fix out atleast. |
Agree on that |
eszkadev
left a comment
There was a problem hiding this comment.
it breaks "scroll to comment" functionality causing random jumps currently (if comment target is not on a screen)
we need to fix that first, before merge (to not exchange bug for bug)
Change-Id: I617603782260d4c3c19e8bdeafc794e3b7457d1d
Summary
buggy comments
before.mp4
fix
after.mp4