Private/caolan/fallback feedback iframe disallowed#15503
Open
Private/caolan/fallback feedback iframe disallowed#15503
Conversation
e.g. like github issue submission page Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com> Change-Id: Ida3cfec06b65cba5e12ceea8599761b32d7e151e
--without-feedback-url or any other --with-feedback-url overrides that Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com> Change-Id: Iab42c3635d5a9e3da4dcfca19f2b7f0beabfeba8
caolanm
force-pushed
the
private/caolan/fallback_feedback_iframe_disallowed
branch
from
d902fc5 to
1e51883
Compare
Contributor
Author
|
The idea here was to have ‘Feedback’ enabled – and point people at github tracker for filing issue. So I thought to default the --with-feedback-url to the github issue submission page (And --without-feedback-url to disable or any other --with-feedback-url to override). Needless to say nothing is trivial and we default to putting feedback in an iframe and github doesn't allow itself to be embedded there, so added a fallback to open in a new tab instead) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TODO
Checklist
make prettier-writeand formatted the code.make checkmake runand manually verified that everything looks okay