fix: fix dynamic zoom display scaling issues in writer#15550
Open
printfdebugging wants to merge 1 commit intomainfrom
Open
fix: fix dynamic zoom display scaling issues in writer#15550printfdebugging wants to merge 1 commit intomainfrom
printfdebugging wants to merge 1 commit intomainfrom
Conversation
- calculateAvailableSpace gets scaled up values for document and container width, so no need to scale that further. - panBy doesn't use scaled up values, but getDocumentScrollOffset returns the offset with scaling applied. So we need to divide that by the scaling factor. Signed-off-by: Sahil Gautam <sahil.gautam@collabora.com> Change-Id: I039761ae5c986c4a9959be509eb46a39370c252c
Contributor
Author
|
please don't merge this yet. although this improves things, it assumes that the document and canvas size are always in sync with the scaling. but as it turns out on browser zoom changes, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
calculateAvailableSpace gets scaled up values for document and container width, so no need to scale that further.
panBy doesn't use scaled up values, but getDocumentScrollOffset returns the offset with scaling applied. So we need to divide that by the scaling factor.
Change-Id: I039761ae5c986c4a9959be509eb46a39370c252c
Summary
TODO
Checklist
make prettier-writeand formatted the code.make checkmake runand manually verified that everything looks okay