Backport 15202#15628
Open
Darshan-upadhyay1110 wants to merge 2 commits intodistro/collabora/co-25.04from
Open
Conversation
- Use flexbox for link row with URL expanded and action buttons right-aligned - Remove arrow from popup card, reduce vertical margin and align spacing - Use object-fit cover on preview images, switch font sizes to rem - Inset preview image with rounded border for clear visual separation - Show fetched page title in the link row and raw URL in the preview - Move preview-update DOM logic into URLPopUpSection.updatePreview() so the popup owns its markup instead of being poked from Map.WOPI.js - Compare previews against the stored url, not the link element's innerText, so follow-up responses are no longer dropped - Update Calc clipboard test to assert the popup container is visible now that the arrow element is gone - Cache the preview and link elements on the section so we avoid repeated getElementById lookups in updatePreview and callbacks Signed-off-by: Darshan-upadhyay1110 <darshan.upadhyay@collabora.com> Change-Id: I6832c4d8ac687d1f939a0a7d10d7526713f1efff
- The 'Copy Hyperlink from pop-up' test was checking for '.arrow-div.reverse' to verify the popup was positioned below the cell without overlap. -The arrow element was removed in the hyperlink tooltip layout cleanup, so the selector no longer matches. - Update the test to check that the hyperlink popup container is visible instead. - The overlap-prevention logic in URLPopUpSection.resetPosition still repositions the popup below the cell when there is no room above, it just no longer renders an arrow. Signed-off-by: Darshan-upadhyay1110 <darshan.upadhyay@collabora.com> Change-Id: Ica42864faf9ab805400a30050a05fbdee2990b5b
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport: #15202
Summary
TODO
Checklist
make prettier-writeand formatted the code.make checkmake runand manually verified that everything looks okay