browser: drop redundant scroll from Comment.highlight() for Draw/Impress#15732
Merged
eszkadev merged 2 commits intodistro/collabora/co-25.04from May 8, 2026
Merged
Conversation
CommentListSection.scrollCommentIntoView, called from navigateAndFocusComment, scrolls to the root comment's anchor. this.position is the marker rectangle of whichever comment in the thread highlightComment iterates over - for a reply on PDF it's hundreds of twips below the anchor, so scrolling to it pushes the anchor out of view. Signed-off-by: Mohit Marathe <mohit.marathe@collabora.com> Change-Id: I80352d6231ca422b2f6767f7868f867b8a0a2116 Reviewed-on: https://gerrit.collaboraoffice.com/c/online/+/2019 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Under heavy CI load, the default 10s retry window expires before the unocommandresult of .uno:ReportWhenIdle arrives, causing intermittent failures. Change-Id: Icf9c1a6b2dc181e2a689c537f1f9085917465b16 Signed-off-by: Mohit Marathe <mohit.marathe@collabora.com> Reviewed-on: https://gerrit.collaboraoffice.com/c/online/+/2067 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
eszkadev
approved these changes
May 8, 2026
Contributor
|
@mohit-marathe please port to gerrit |
Contributor
Author
@eszkadev it was first merged in gerrit: https://gerrit.collaboraoffice.com/c/online/+/2019. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
draw/annotation_spec.jsflakiness