share syncDocumentLogoAriaLabel for menubar variant#15736
Open
caolanm wants to merge 1 commit intodistro/collabora/co-25.04from
Open
share syncDocumentLogoAriaLabel for menubar variant#15736caolanm wants to merge 1 commit intodistro/collabora/co-25.04from
caolanm wants to merge 1 commit intodistro/collabora/co-25.04from
Conversation
Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com> Change-Id: Id0ee954d4132da47107d3df07199abf039b5c536 Reviewed-on: https://gerrit.collaboraoffice.com/c/online/+/1773 Tested-by: Jenkins CPCI <releng@collaboraoffice.com> Reviewed-by: Parth Raiyani <parth.raiyani@collabora.com>
caolanm
force-pushed
the
private/caolan/sync_document_logo25
branch
from
bdaa2c1 to
c497187
Compare
Contributor
Author
|
This is a backport to sync the classic menubar "logo" button case with the notebookbar "logo" button, where if the branding make the button open a new tab then we a11y announce that is what it will do |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change-Id: Id0ee954d4132da47107d3df07199abf039b5c536
Reviewed-on: https://gerrit.collaboraoffice.com/c/online/+/1773
Tested-by: Jenkins CPCI releng@collaboraoffice.com
Reviewed-by: Parth Raiyani parth.raiyani@collabora.com
Summary
TODO
Checklist
make prettier-writeand formatted the code.make checkmake runand manually verified that everything looks okay