Conversation
Collaborator
Author
|
@ThomasPiellard this is just consolidating GLV in twisted Edwards with Weiestrass. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When we revisited GLV scalar decomposition #213, we increased conditionally the loop bounds by 1 for all
mulGLVmethods for all curves but we forgot to do so for Bandersnatch twisted Edwards curve. This PR fixes the issue.Type of change
How has this been tested?
added
scalarMulWindowedwhich does a windowed double-and-add and compares the result withscalarMulGLVwhich uses the endomorphism. The methodScalarMultiplicationpicksscalarMulGLVwhenever an efficient endomorphism is available (currently only for Bandersnatch).How has this been benchmarked?
No major diff for random scalars.
Checklist:
golangci-lintdoes not output errors locally