Conversation
gbotrel
approved these changes
Jun 22, 2022
ThomasPiellard
approved these changes
Jun 22, 2022
Merged
This was referenced Jun 27, 2024
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This replaces the Babai rounding at runtime in
SplitScalar()by a right-shift. We precomputeb=2^m*v/d(m > log2(d)) and then at runtime computescalar*b/2^m. This increases the bounds on sub-scalars by 1 which we check at runtime before increasing the loop size (we don't target constant-timeness).mis chosen to be a machine word twice big thanlog2(d)so that we rarely increase the loop size.