chore: generify poseidon2 parameters for other curves/fr#636
Merged
Conversation
Tabaie
approved these changes
Feb 17, 2025
Contributor
Tabaie
left a comment
There was a problem hiding this comment.
LGTM except for that commented block
Collaborator
|
Can you rebase one top of #629 ? (i.e. update this PR to include small fields, and set it to merge on feat/poseidon2-koala+baby-bear instead of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Generify poseidon2 parameters for other curves/fr
Type of change
How has this been tested?
N/A
How has this been benchmarked?
N/A
Checklist:
golangci-lintdoes not output errors locally