Skip to content

feat: poseidon2 for koala-bear, baby-bear and goldilocks#629

Merged
yelhousni merged 17 commits intomasterfrom
feat/poseidon2-koala+baby-bear
Feb 18, 2025
Merged

feat: poseidon2 for koala-bear, baby-bear and goldilocks#629
yelhousni merged 17 commits intomasterfrom
feat/poseidon2-koala+baby-bear

Conversation

@yelhousni
Copy link
Copy Markdown
Collaborator

@yelhousni yelhousni commented Feb 7, 2025

Description

This PR adds support of poseidon2 hash on small fields: baby-bear, koala-bear and goldilocks.

Type of change

  • New feature (non-breaking change which adds functionality)

How has this been tested?

How has this been benchmarked?

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I did not modify files generated from templates
  • golangci-lint does not output errors locally
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@yelhousni yelhousni marked this pull request as draft February 7, 2025 18:37
@yelhousni yelhousni marked this pull request as ready for review February 7, 2025 19:25
@yelhousni yelhousni added type: new feature type: consolidate strengthen an existing feature dep: linea Issues affecting downstream Linea labels Feb 7, 2025
@yelhousni yelhousni added this to the v0.10.0 milestone Feb 7, 2025
@yelhousni yelhousni changed the title feat: poseidon2 for koala-bear and baby-bear feat: poseidon2 for koala-bear, baby-bear and goldilocks Feb 10, 2025
@yelhousni yelhousni changed the title feat: poseidon2 for koala-bear, baby-bear and goldilocks feat: poseidon2 for koala-bear and baby-bear Feb 11, 2025
@yelhousni yelhousni changed the title feat: poseidon2 for koala-bear and baby-bear feat: poseidon2 for koala-bear, baby-bear and goldilocks Feb 14, 2025
@yelhousni yelhousni requested a review from gbotrel February 14, 2025 22:09
Copy link
Copy Markdown
Contributor

@Tabaie Tabaie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All lgtm except for the Merkle-Damgard stuff, which I think we should take out until we generify it to support widths other than 2.

Also, I'm not familiar with how the matrices are computed so I didn't verify those.

@yelhousni yelhousni requested a review from gbotrel February 18, 2025 17:59
@yelhousni yelhousni merged commit 948bd32 into master Feb 18, 2025
@yelhousni yelhousni deleted the feat/poseidon2-koala+baby-bear branch February 18, 2025 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dep: linea Issues affecting downstream Linea type: consolidate strengthen an existing feature type: new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants