feat: poseidon2 for koala-bear, baby-bear and goldilocks#629
Merged
feat: poseidon2 for koala-bear, baby-bear and goldilocks#629
Conversation
Tabaie
requested changes
Feb 15, 2025
Contributor
Tabaie
left a comment
There was a problem hiding this comment.
All lgtm except for the Merkle-Damgard stuff, which I think we should take out until we generify it to support widths other than 2.
Also, I'm not familiar with how the matrices are computed so I didn't verify those.
gbotrel
requested changes
Feb 17, 2025
9 tasks
Tabaie
approved these changes
Feb 18, 2025
gbotrel
approved these changes
Feb 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support of poseidon2 hash on small fields: baby-bear, koala-bear and goldilocks.
Type of change
How has this been tested?
How has this been benchmarked?
Checklist:
golangci-lintdoes not output errors locally