Skip to content

Throw an error when inverse by 0 in BatchCompressTorus()#222

Merged
gbotrel merged 3 commits intodevelopfrom
fix/BatchCompressTorus
Jul 27, 2022
Merged

Throw an error when inverse by 0 in BatchCompressTorus()#222
gbotrel merged 3 commits intodevelopfrom
fix/BatchCompressTorus

Conversation

@yelhousni
Copy link
Copy Markdown
Collaborator

No description provided.

@yelhousni yelhousni requested a review from gbotrel July 26, 2022 21:07
@gbotrel
Copy link
Copy Markdown
Collaborator

gbotrel commented Jul 27, 2022

So, do we explicitly say that batchInverse returns 0 for inv(0)?

@yelhousni
Copy link
Copy Markdown
Collaborator Author

if this gets merged we can keep inv(0)=0

@gbotrel
Copy link
Copy Markdown
Collaborator

gbotrel commented Jul 27, 2022

OK but we will need to document BatchInvert independently; since it's a public function it can be used in other places.

@gbotrel gbotrel merged commit 910b0ec into develop Jul 27, 2022
@gbotrel gbotrel deleted the fix/BatchCompressTorus branch July 27, 2022 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants