Skip to content

Replace partitionScalarOld by partitionScalar in batchScalarMul#284

Merged
gbotrel merged 5 commits intodevelopfrom
gbotrel/issue268
Dec 16, 2022
Merged

Replace partitionScalarOld by partitionScalar in batchScalarMul#284
gbotrel merged 5 commits intodevelopfrom
gbotrel/issue268

Conversation

@gbotrel
Copy link
Copy Markdown
Collaborator

@gbotrel gbotrel commented Dec 14, 2022

  • checkpoint
  • feat: replace partitionScalarOld by partitionScalar

@gbotrel gbotrel requested a review from yelhousni December 16, 2022 03:42
Copy link
Copy Markdown
Collaborator

@yelhousni yelhousni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
We might revisit partitionScalars for secp256k1 to allow a path when a spare bit is not available.

@gbotrel
Copy link
Copy Markdown
Collaborator Author

gbotrel commented Dec 16, 2022

ha, well, I think this new partitionScalars would work as is; the returned values is a list of []uint16 digits, so normally we would just have a last window that's larger than c. The only issue is that... if we have c = 16 and lastC = 17, the digits don't fit on uint16 🙃
(so... as a cheat, if in the template for secp we have a special case to limit the choice of c to 15, we should be good.)

@gbotrel gbotrel merged commit 0638b77 into develop Dec 16, 2022
@gbotrel gbotrel deleted the gbotrel/issue268 branch December 16, 2022 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

BatchScalarMultiplication uses partitionScalarOld: merge with partitionScalar

2 participants