Avoid unnecessary big.Int assignment#292
Closed
jsign wants to merge 4 commits intoConsensys:developfrom
Closed
Conversation
docs: added audit report
Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com>
Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com>
jsign
changed the title
jsign
commented
Dec 23, 2022
| vv := bigIntPool.Get().(*big.Int) | ||
|
|
||
| // copy input + modular reduction | ||
| vv.Set(v) |
Contributor
Author
There was a problem hiding this comment.
vv will be used as an output variable in the operation next line, so we can the value assignment.
gbotrel
added a commit
that referenced
this pull request
Jan 5, 2023
* docs: added audit.pdf and updated link in README * internal/field: avoid unnecessary assignement Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com> * generate: run go generate Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com> * build: go generate no gkr for secp Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com> Co-authored-by: Youssef El Housni <youssef.elhousni@consensys.net> Co-authored-by: Ignacio Hagopian <jsign.uy@gmail.com>
Collaborator
|
cherry picked in #296 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes an unnecessary assignment to an output variable.