Skip to content

321 bn254mimc test vector#323

Merged
gbotrel merged 5 commits intodevelopfrom
321-bn254mimc-test-vector
Feb 13, 2023
Merged

321 bn254mimc test vector#323
gbotrel merged 5 commits intodevelopfrom
321-bn254mimc-test-vector

Conversation

@Tabaie
Copy link
Copy Markdown
Contributor

@Tabaie Tabaie commented Jan 31, 2023

Simple test vector generator for MiMC - BN254.

Possible other features:

  • Include result by round (or every 10 rounds so that the test entries are smaller)
  • Include test cases with custom string input (conventionally hashed to fr first)

@Tabaie Tabaie requested a review from gbotrel January 31, 2023 21:26
@gbotrel
Copy link
Copy Markdown
Collaborator

gbotrel commented Feb 1, 2023

looks good, may be worth it to have at least one vector that takes multiple elements as input. I believe the intended use case is state manager so I hear "merkle tree path" 👍

@gbotrel gbotrel merged commit 7444bbb into develop Feb 13, 2023
@gbotrel gbotrel deleted the 321-bn254mimc-test-vector branch February 13, 2023 00:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants