Merged
Conversation
Tabaie
approved these changes
Feb 9, 2023
| workers := utils.NewWorkerPool() | ||
| o.pool = &pool | ||
| o.workers = &workers | ||
| o.workers = workers |
Contributor
There was a problem hiding this comment.
Is this a must? In the gnark API, I was creating a pool of workers for the GKR solver first and then passing the same one to the prover instead of taking it down and setting it up again, hence the pointer.
Collaborator
Author
There was a problem hiding this comment.
utils.NewWorkerPool returns a pointer 👍
Collaborator
Author
There was a problem hiding this comment.
(that being said, the pool is lightweight and it's OK to have 2 pools that are properly stopped using the "Stop" method between Solver and Prover; memory wise with stack / heap usage of the go routine of the pool that may actually work better (to be seen :))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On my M1 laptop for bn254 gkr+mimc benchmarks (didn't test on the hpc machine, can you do it @Tabaie ? )