Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
317 commits
Select commit Hold shift + click to select a range
c84ad6a
fix: better string search to make staticcheck happy
Tabaie Oct 10, 2022
abba654
fix: more staticcheck fixes
Tabaie Oct 10, 2022
37daf92
feat: remove unused test hash entries
Tabaie Oct 10, 2022
6fa4f44
style: rename rational_cases to test_vectors
Tabaie Oct 11, 2022
ec922fe
fix: restored hash elements incorrectly marked as unnecessary
Tabaie Oct 11, 2022
f6c1e99
refactor: smallRational out of gkr
Tabaie Oct 26, 2022
639efd2
feat: parsing polynomials; more trouble than worth
Tabaie Oct 26, 2022
7c22e60
refactor: move some routines from gkrVectors
Tabaie Oct 26, 2022
018d797
test: a simple test vector for sumcheck
Tabaie Oct 27, 2022
3d63c81
test: trilinear - single claim
Tabaie Oct 27, 2022
321be58
style: format
Tabaie Oct 31, 2022
bbd7a2d
feat: a first attempt at separate test vector utils
Tabaie Oct 31, 2022
fbfa7e5
fix: some corrections for rationals
Tabaie Oct 31, 2022
1b7cb97
fix: rough edges for rationals
Tabaie Oct 31, 2022
8a0d0cf
feat: test vector utils for all
Tabaie Oct 31, 2022
6324a66
refactor: generify most gkr test vector ops
Tabaie Nov 1, 2022
d68cab4
fix: minor ones
Tabaie Nov 1, 2022
5ad4fb8
fix: wrong type for wireAssignent
Tabaie Nov 1, 2022
25d25e0
feat!: autogenerate test vector generator. crashes :p
Tabaie Nov 1, 2022
55eb52f
fix: snapshot: gkr test vector generation
Tabaie Nov 1, 2022
891e553
fix: manually edited main.go for gkr test vec gen
Tabaie Nov 1, 2022
a599ebb
fix: test vec gen works
Tabaie Nov 1, 2022
fac3ce1
fix: remove auto-generated test files
Tabaie Nov 1, 2022
79002ab
refactor: remove "proofEquals" from gkr test vgen
Tabaie Nov 1, 2022
b9694f0
Merge branch 'develop' into test/gkr-autogen
Tabaie Nov 1, 2022
249e126
fix: snapshot for hash inconsistency error
Tabaie Nov 2, 2022
0cce4b4
fix: still inconsistency betw rational and bn254
Tabaie Nov 2, 2022
1816e29
fix: save new hash entries
Tabaie Nov 2, 2022
01f9b0d
fix: writeKey quotation marks
Tabaie Nov 2, 2022
3e80ef9
fix: remove unreachable return
Tabaie Nov 2, 2022
3984c4b
test: add failing verification tests
Tabaie Nov 2, 2022
0be2c48
style: remove some dead code
Tabaie Nov 2, 2022
27d0575
feat: basic benchmarking
Tabaie Nov 3, 2022
589a6a4
perf: reduced many memory leaks to two
Tabaie Nov 4, 2022
a07a181
test: bigger instances
Tabaie Nov 4, 2022
a23811d
feat!: pool class, functions cleaned up
Tabaie Nov 4, 2022
a0a58ed
feat: clean ups
Tabaie Nov 4, 2022
c13d15e
perf: some rudimentary parallelism
Tabaie Nov 4, 2022
e720cd3
feat: generic pool
Tabaie Nov 4, 2022
5cf319a
Revert "feat: generic pool"
Tabaie Nov 4, 2022
9a643f7
feat: generified benchmark, parallelism and top sort
Tabaie Nov 4, 2022
0bdf14b
fix: errors in rational sumcheck
Tabaie Nov 4, 2022
65b0965
fix: an "evaluate" missing the pool argument
Tabaie Nov 7, 2022
4fbda14
fix: free mallocs
Tabaie Nov 8, 2022
022544c
revert: roll back cgo in memory management
Tabaie Nov 8, 2022
925d59e
fix: remove "enormousArray" hack, minimize unsafe.Pointer use
Tabaie Nov 8, 2022
7d0b0d9
fix: yoda, multi-fan-out input bug
Tabaie Nov 8, 2022
3e5e622
feat: generify multi-fan-out input bugfix
Tabaie Nov 8, 2022
9a5c4d9
style: remove unnecessary variable
Tabaie Nov 8, 2022
decd881
test: vector with 4 instances
Tabaie Nov 8, 2022
a4883c6
Merge pull request #259 from ConsenSys/bench/gkr
Tabaie Nov 9, 2022
eb89829
Merge branch 'develop' into feat/gkr
Tabaie Dec 7, 2022
8383d27
fix: gofmt
Tabaie Dec 8, 2022
f585adf
feat: add minimal implem of stark curve
yelhousni Dec 9, 2022
bb4a701
feat: three kinds of topological sort
Tabaie Dec 9, 2022
f1e7c59
chore: remove two other topological sorts
Tabaie Dec 9, 2022
ac47d14
chore: setNbOutputs covered by topSort now
Tabaie Dec 9, 2022
1ebf9d2
fix: bn254 seems correct. test vector reordering needed
Tabaie Dec 9, 2022
62f319b
feat: SliceToElementSlice to be generic
Tabaie Dec 9, 2022
a62eef4
feat: generify gkr.tmpl
Tabaie Dec 9, 2022
b82f267
feat: some test generification
Tabaie Dec 9, 2022
fc596d3
feat: generified gkr tests. test case generation still not working
Tabaie Dec 9, 2022
f6a6639
fix: generification
Tabaie Dec 10, 2022
80472d9
chore: delete temp files
Tabaie Dec 10, 2022
818b3f9
fix: reintroduce some deleted autogens
Tabaie Dec 10, 2022
d46b53c
fix: topological sort no longer group inputs and outputs
Tabaie Dec 10, 2022
2ab9344
fix: no expectation of ins/outs lumped together in tests
Tabaie Dec 10, 2022
57a0929
fix: multi-counting outs to the same wire
Tabaie Dec 10, 2022
1d6b211
fix: static checks
Tabaie Dec 10, 2022
9fd0a7d
fix(stark-curve): svdw hash-to-curve (coeff A!=0)
yelhousni Dec 12, 2022
2e025c8
refactor: sumcheck and gkr to use fiatshamir package
Tabaie Dec 12, 2022
f809a99
fix: bn254 sumcheck tests pass
Tabaie Dec 12, 2022
d1b53ae
refactor: fixing gkr tests
Tabaie Dec 12, 2022
1f58e43
feat: small_rational to and from bytes
Tabaie Dec 13, 2022
8481687
feat: generify sumcheck changes
Tabaie Dec 13, 2022
a43e7b3
refactor: remove unused file
Tabaie Dec 13, 2022
8e8e1ba
chore: remove codegen temp files
Tabaie Dec 13, 2022
411b9e1
feat: generify gkr changes
Tabaie Dec 13, 2022
2e79128
feat: generify non-test vector gkr test changes
Tabaie Dec 13, 2022
a9fd9d5
refactor: gkr tests to work with fiatshamir.transcript
Tabaie Dec 13, 2022
5ae08af
fix: gkr_test files compile
Tabaie Dec 13, 2022
2204819
fix: gkr test case generator compiles
Tabaie Dec 13, 2022
948fa93
fix: sumcheck testcase gen compiles
Tabaie Dec 13, 2022
f45b154
fix: gkr challenges for SmallRational
Tabaie Dec 14, 2022
9e80c85
feat: generify gkr fixes
Tabaie Dec 14, 2022
463fce2
test: MapHash consistency
Tabaie Dec 14, 2022
7516cf9
fix: no hardcoded fr.Element in sumcheck test case gen
Tabaie Dec 14, 2022
a451805
refactor: get rid of ParsedTestCase
Tabaie Dec 14, 2022
54425c0
fix: some gkr test vec errors
Tabaie Dec 14, 2022
91a7dec
fix: staticcheck
Tabaie Dec 14, 2022
706253c
refactor: cleaner sumcheck test-vec generation
Tabaie Dec 14, 2022
4d8ab50
fix: fake hash consistency
Tabaie Dec 14, 2022
74ac504
fix: generify changes in small_rational maphashes
Tabaie Dec 14, 2022
ffa1953
fix: gkr test-vec gen errors
Tabaie Dec 14, 2022
29c4578
feat: generify gkr test vec gen fixes
Tabaie Dec 14, 2022
d5b2980
fix: uncomment gkr test vec gen
Tabaie Dec 14, 2022
166b084
fix: staticcheck
Tabaie Dec 14, 2022
c5be1d7
refactor: move all fake hashes to test_vector_utils
Tabaie Dec 14, 2022
54ae7d2
fix: MessageCounter.Reset
Tabaie Dec 14, 2022
c4a58f6
feat: generify MessageCounter fix
Tabaie Dec 14, 2022
7d7bf15
fix: sumcheck claim test
Tabaie Dec 14, 2022
9f9799a
fix: accepting bad proofs
Tabaie Dec 14, 2022
a3e2179
fix: sumcheck "bad proof accepted"
Tabaie Dec 15, 2022
fce4760
Merge pull request #285 from ConsenSys/refac/gkr-fiatshamir
Tabaie Dec 15, 2022
a05f11d
fix: ignored errors in sumcheck.setupTranscript
Tabaie Dec 15, 2022
72fe8c9
style: some simplification, remove some dead code
Tabaie Dec 15, 2022
b8708dc
revert: don't doubly hash finalEvalProof when an input wire is skipped
Tabaie Dec 15, 2022
0e04dab
fix: no repeated claims in FinalEvalProof
Tabaie Dec 15, 2022
a81f1c1
test: replicate failure in small_rational
Tabaie Dec 15, 2022
ca51482
fix: noRedundancy bugs
Tabaie Dec 15, 2022
246bf8f
fix: more noRedundancy bugs
Tabaie Dec 15, 2022
848f31a
fix: verifier input building bug
Tabaie Dec 16, 2022
cecaa28
fix: generify the fix
Tabaie Dec 16, 2022
81eb7a7
fix: correct field type
Tabaie Dec 16, 2022
8e08a54
feat: ListHash
Tabaie Dec 17, 2022
d3c6c1c
Merge branch 'develop' into feat/gkr
Tabaie Dec 19, 2022
0c7d223
fix: package name
Tabaie Dec 19, 2022
cc55ecd
Merge branch 'develop' into feat/gkr
Tabaie Dec 20, 2022
06399fb
feat: MSM and BatchScalarMul on secp256k1
yelhousni Dec 21, 2022
9aef96e
refactor: include secp256k1 in code generation
yelhousni Dec 21, 2022
777bf44
refactor: include secp256k1 in code generation
yelhousni Dec 21, 2022
11a670e
fix(template): entries var re-declared
yelhousni Dec 21, 2022
be11d9e
fix(secp256k1): bound cRrange by 15 for MSM
yelhousni Dec 21, 2022
cfc7110
fix(secp256k1): code generation for msm
yelhousni Jan 6, 2023
1d3ad3b
Merge branch 'develop' into secp256k1/MSM
yelhousni Jan 7, 2023
b96a52e
build: remove G2Exist flag from curves config
yelhousni Jan 7, 2023
dbd7531
refactor: remove fr/ packages from secp256k1
yelhousni Jan 7, 2023
fb29688
refactor: remove dead code (FFT params for secp256k1)
yelhousni Jan 9, 2023
2d53c65
fix: merge with develop
yelhousni Jan 9, 2023
fe0cb5f
feat: generate fp with addchain stark-curve
gbotrel Jan 9, 2023
93fe074
Merge pull request #299 from ConsenSys/feat/stark-curve
yelhousni Jan 11, 2023
87abefd
feat: start ECDSA on secp256k1
yelhousni Jan 11, 2023
bca4322
fix: ecdsa on secp256k1 working
yelhousni Jan 12, 2023
7e3e95f
test: failing test
Tabaie Jan 12, 2023
0fc8672
fix: align challenge name, prepending with zeros to avoid field overflow
Tabaie Jan 12, 2023
d418e28
Merge pull request #305 from ConsenSys/test/fiatshamir-mimc
Tabaie Jan 12, 2023
6948d85
feat(ecdsa): use aes-ctr in signing randomness
yelhousni Jan 16, 2023
6ed76e6
feat: decomposing long challenge names bn254
Tabaie Jan 16, 2023
31f311a
feat: generify Decomposition solution
Tabaie Jan 16, 2023
bb6a866
feat: more usable WriteString instead of "Decompose"
Tabaie Jan 16, 2023
eaa4a16
fix: eddsa to use WriteString
Tabaie Jan 16, 2023
7140b8f
fix: minor error
Tabaie Jan 16, 2023
06d1651
fix: eddsa: separate field element and non-field-element hash inputs
Tabaie Jan 16, 2023
4d68b9c
chore: ToBigIntRegular -> BigInt
Tabaie Jan 16, 2023
c13ecaf
chore: more ToBigIntRegular -> BigInt and another little thing
Tabaie Jan 16, 2023
c8ecac9
refactor(ecdsa): follows SEC 1 v-2
yelhousni Jan 17, 2023
50fab2e
feat(templates): ecdsa package for all curves
yelhousni Jan 18, 2023
dbd95c7
test: add ecdsa benchmarks
yelhousni Jan 18, 2023
863d067
perf(ecdsa): avoid 2 inverses in verify (affine scalarMul)
yelhousni Jan 18, 2023
1dd6e2e
fix(ecdsa): avoid only 1 inverse in verify
yelhousni Jan 18, 2023
c07f70d
perf(stark-curve/ecdsa): faster verification with JointScalarMul
yelhousni Jan 19, 2023
c826abb
perf(all curves/ecdsa): faster verification with JointScalarMul
yelhousni Jan 19, 2023
0225611
Merge branch 'develop' into secp256k1/MSM
yelhousni Jan 19, 2023
be6076f
Merge pull request #309 from ConsenSys/chore/tobigintregular-deprecated
gbotrel Jan 19, 2023
96584ad
Merge pull request #298 from ConsenSys/secp256k1/MSM
gbotrel Jan 19, 2023
92008e9
refactor(ecdsa): make public params exportable to gnark
yelhousni Jan 20, 2023
96af55a
fix(curves): copy scalars in JointScalarMul
yelhousni Jan 20, 2023
eb8bce9
refactor(ecdsa): remove Params struct
yelhousni Jan 20, 2023
1388400
Merge branch 'develop' into feat/ecdsa
yelhousni Jan 20, 2023
12ea0ab
refactor(ecdsa): marshal + follow interface
yelhousni Jan 23, 2023
a08e819
refactor: concile ecdsa and eddsa on signature interface
yelhousni Jan 24, 2023
7fddebf
fix: serialization of stark-curve points
yelhousni Jan 24, 2023
0b2c0d5
fix(stark-curve): point encoder (a!=0)
yelhousni Jan 24, 2023
ef3b0d7
refactor(ecdsa): make hashToInt accessible for gnark
yelhousni Jan 24, 2023
a95338a
refactor: element imports field/pool and field/hash to avoid cycles
gbotrel Jan 24, 2023
e23e219
feat: adds Vector in field package
gbotrel Jan 24, 2023
1f288ef
refactor: plookup.Table -> fr.Vector
gbotrel Jan 24, 2023
13057cd
test: a couple of benchmarks with some printfs
Tabaie Jan 24, 2023
82d2975
perf: concurrency in computeGJ. to make pool maps thread-safe
Tabaie Jan 25, 2023
e952342
feat: thread-safe pool
Tabaie Jan 25, 2023
3a3d8d1
fix: side-stepped thread-safe pool issue
Tabaie Jan 25, 2023
775d218
feat: pre-hashed message in ecdsa
yelhousni Jan 25, 2023
44a28b6
feat: pre-hashed message in eddsa
yelhousni Jan 25, 2023
9b7bfdb
Merge pull request #310 from ConsenSys/feat/ecdsa
yelhousni Jan 25, 2023
6b67898
perf: parallelism in computeGJ but faulty
Tabaie Jan 25, 2023
5798dc8
feat: generify parallel.Execute
Tabaie Jan 26, 2023
71ad8f3
feat: hash.ToField compatible with hash.Hash
Tabaie Jan 26, 2023
4d64a23
build: generify bn254 mimc changes
Tabaie Jan 26, 2023
7a3a188
chore: staticcheck
Tabaie Jan 26, 2023
1415737
Merge branch 'chore/tobigintregular-deprecated' into 304-field-agnost…
Tabaie Jan 26, 2023
0f21a1d
fix: WriteString returns no error now
Tabaie Jan 26, 2023
96ff306
feat: edDSA to write element by element
Tabaie Jan 26, 2023
1835092
Merge pull request #311 from ConsenSys/feat/element/vector
gbotrel Jan 26, 2023
b49eb79
perf(ecdsa): no bigInt allocation
yelhousni Jan 27, 2023
122af52
fix(EdDSA): enforce hash function as FS challenge
yelhousni Jan 27, 2023
168e105
feat: more "subtle" parallelization tools
Tabaie Jan 27, 2023
ebca041
perf: workerPool in gkr
Tabaie Jan 27, 2023
bf32698
feat: parallel versions of computing gate inputs
Tabaie Jan 27, 2023
2b35aca
perf: parallelize computeGJ more effectively
Tabaie Jan 27, 2023
22599b7
build: generify parallel computeGJ
Tabaie Jan 27, 2023
3241009
fix: parallelization bug
Tabaie Jan 27, 2023
7c02355
build: generify fixes
Tabaie Jan 27, 2023
a53b36b
perf: parallel WireAssignment.Complete for bn254
Tabaie Jan 28, 2023
0dc9442
build: generify parallel .Complete
Tabaie Jan 28, 2023
25572a8
feat: can pass workers pool in
Tabaie Jan 28, 2023
6a5cd08
feat: gkr.Circuit.MemoryRequirements
Tabaie Jan 28, 2023
0defd20
perf: parallel Fold
Tabaie Jan 30, 2023
7841c97
fix: sumcheck test
Tabaie Jan 30, 2023
9d9a6a9
build: generify
Tabaie Jan 30, 2023
1a3bd6c
refactor: remove Decompose entirely
Tabaie Jan 30, 2023
861de54
chore: simpler dst for hash.WriteString
Tabaie Jan 30, 2023
f2ee7f0
fix: number of rounds for mimc
yelhousni Jan 30, 2023
17e54bc
fix: fiatshamir to write bindings one by one
Tabaie Jan 30, 2023
6679aff
feat: edDsa SignFr and VerifyFr
Tabaie Jan 30, 2023
81ae8e0
feat: signing interface changes and bn254 impl
Tabaie Jan 30, 2023
9cfd858
build: generify
Tabaie Jan 30, 2023
62c5ffa
perf: mimc on bls12-377/fr uses x^17 as a permutation
yelhousni Jan 31, 2023
97cb629
Merge pull request #312 from ConsenSys/signature/pre-hashed
yelhousni Jan 31, 2023
b4237f2
Merge pull request #320 from ConsenSys/fix/mimc-rounds
yelhousni Jan 31, 2023
f403083
feat: pedersen_hash added to stark curve
anshulforyou Feb 1, 2023
46d9e86
feat: Merkle tree to panic upon hash write error
Tabaie Feb 1, 2023
c15c344
Merge branch 'develop' into 304-field-agnostic-fiat-shamir-challenge-…
Tabaie Feb 2, 2023
389d5e4
revert: mimc to take in multiple elements
Tabaie Feb 2, 2023
fa19919
revert: remove SignNum and VerifyNum
Tabaie Feb 2, 2023
4dd000a
revert: Remove EdDSA SignNum and VerifyNum
Tabaie Feb 2, 2023
aa62b7e
build: weird staticcheck rule
Tabaie Feb 2, 2023
c9b64ee
revert: deleted mimc.Write documentation
Tabaie Feb 2, 2023
28a5eb3
test: mimc to write out its ins and outs
Tabaie Feb 2, 2023
8126db3
test: printfs in mimc
Tabaie Feb 2, 2023
630e96d
test: more debug output
Tabaie Feb 2, 2023
6bf593d
refactor: Pedersen hash on stark-curve
yelhousni Feb 3, 2023
b05a402
perf(stark-curve/perdersen-hash): use Strauss-Shamir scalarMul
yelhousni Feb 3, 2023
f81b94d
Revert "perf(stark-curve/perdersen-hash): use Strauss-Shamir scalarMul"
yelhousni Feb 3, 2023
e77b091
Merge pull request #327 from ConsenSys/pedersen-hash
yelhousni Feb 3, 2023
15c1494
perf: simplify gkr pool
gbotrel Feb 3, 2023
ebbf6ea
perf: step 1, use the new pool for computeGJ and next
gbotrel Feb 3, 2023
2554403
perf: step 2 Combine
gbotrel Feb 3, 2023
12e7a69
perf: multilin.Fold without writing top part in memory
gbotrel Feb 3, 2023
3f2dbb8
fix: mimc pow7
yelhousni Feb 6, 2023
3169a17
fix: closes #316 big int pool doesn't allow nil values
gbotrel Feb 6, 2023
bd58bea
feat: nuke element.Bit() closes #306 (#331)
gbotrel Feb 8, 2023
632763c
Feat/iop arguments (#282)
ThomasPiellard Feb 9, 2023
9bff357
Merge pull request #333 from ConsenSys/fix/mimc-pow7
Tabaie Feb 9, 2023
81a52c8
Merge branch 'develop' into 304-field-agnostic-fiat-shamir-challenge-…
Tabaie Feb 9, 2023
d3cbaa7
docs: innerWork
Tabaie Feb 9, 2023
28d50bc
docs: fix incorrect statement
Tabaie Feb 9, 2023
2ea67b1
perf: minor adjustements to iop package (#334)
gbotrel Feb 9, 2023
a83456a
fix: remove mimc printfs
Tabaie Feb 9, 2023
045e689
Merge pull request #328 from ConsenSys/perf/gkrpool
Tabaie Feb 10, 2023
9a6a284
Merge branch 'develop' into perf/gkr
Tabaie Feb 10, 2023
99ea21d
build: go generate
Tabaie Feb 10, 2023
4add393
chore: remove safeStack
Tabaie Feb 10, 2023
a40378c
refactor: remove ToField interface
Tabaie Feb 10, 2023
6f591e7
Merge pull request #319 from ConsenSys/perf/gkr
Tabaie Feb 10, 2023
a3a667b
Merge pull request #308 from ConsenSys/304-field-agnostic-fiat-shamir…
Tabaie Feb 10, 2023
813c621
feat: add Vector support to ecc marshal encoder (#336)
gbotrel Feb 13, 2023
6f76ca2
Refactor/no map hash (#338)
Tabaie Feb 13, 2023
7444bbb
321 bn254mimc test vector (#323)
Tabaie Feb 13, 2023
c9721e1
refactor: clean iop APIs + add Marshal methods (#337)
gbotrel Feb 14, 2023
fa13388
Revert "feat: simplified putInExpectedForm"
gbotrel Feb 14, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
5 changes: 4 additions & 1 deletion accumulator/merkletree/tree.go
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,10 @@ func sum(h hash.Hash, data ...[]byte) []byte {

for _, d := range data {
// the Hash interface specifies that Write never returns an error
_, _ = h.Write(d)
_, err := h.Write(d)
if err != nil {
panic(err)
}
}
return h.Sum(nil)
}
Expand Down
28 changes: 28 additions & 0 deletions ecc/bls12-377/ecdsa/doc.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

306 changes: 306 additions & 0 deletions ecc/bls12-377/ecdsa/ecdsa.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading