Conversation
Summary✅ Passed: 5883 🚧 Skipped
|
Summary✅ Passed: 5883 🚧 Skipped
|
yelhousni
approved these changes
Sep 29, 2023
Collaborator
yelhousni
left a comment
There was a problem hiding this comment.
All looks good 👍
The last two commits just fix few typos and some cosmetics:
- merges the new (exp, expGLV) with the old (exp, expGLV and CyclotomicExp) test;
- uses
genAvariable to switchGenE12()forGenE24()orGenE6()when needed; - uses
{{ toUpper .Name}}for curves' names instead of BN254 in the new test; - manually apply the fix (and test) to BLS24-* and BW6-* as the towers are not auto-generated there.
gbotrel
reviewed
Oct 5, 2023
|
|
||
| res.Set(&g1Infinity) | ||
| ops[0].Set(a) | ||
| e := s |
Collaborator
There was a problem hiding this comment.
@yelhousni @ThomasPiellard this snippet is weird? didn't review this PR but to me this code is useless.
What does this code do; assign a *big.Int, overwrites it with an object from a pool, and Neg(s) into e, the object of the pool before discarding it.
holiman
reviewed
Oct 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Type of change
How has this been tested?
Checklist: