Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes the GKR components from gnark-crypto in preparation for moving them to gnark.
- Removed all sumcheck and GKR registry files for various curves (bn254, bls24-317, bls24-315, bls12-381, bls12-377)
- Removed related test vector utilities and Poseidon2 gkrgate implementations
Reviewed Changes
Copilot reviewed 96 out of 96 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| ecc/bn254/fr/sumcheck/sumcheck_test.go | Removed GKR-related sumcheck test code for bn254 |
| ecc/bn254/fr/sumcheck/sumcheck.go | Removed GKR-related sumcheck implementation for bn254 |
| ecc/bn254/fr/gkr/registry.go | Removed GKR registry file for bn254 |
| ecc/bls24-317/fr/test_vector_utils/test_vector_utils.go | Removed test vector utilities for bls24-317 |
| ecc/bls24-317/fr/sumcheck/sumcheck_test.go | Removed sumcheck tests for bls24-317 |
| ecc/bls24-317/fr/sumcheck/sumcheck.go | Removed sumcheck code for bls24-317 |
| ecc/bls24-317/fr/gkr/registry.go | Removed GKR registry for bls24-317 |
| ecc/bls24-315/fr/test_vector_utils/test_vector_utils.go | Removed test vector utilities for bls24-315 |
| ecc/bls24-315/fr/sumcheck/sumcheck_test.go | Removed sumcheck tests for bls24-315 |
| ecc/bls24-315/fr/sumcheck/sumcheck.go | Removed sumcheck code for bls24-315 |
| ecc/bls24-315/fr/gkr/registry.go | Removed GKR registry for bls24-315 |
| ecc/bls12-381/fr/test_vector_utils/test_vector_utils.go | Removed test vector utilities for bls12-381 |
| ecc/bls12-381/fr/sumcheck/sumcheck_test.go | Removed sumcheck tests for bls12-381 |
| ecc/bls12-381/fr/sumcheck/sumcheck.go | Removed sumcheck code for bls12-381 |
| ecc/bls12-381/fr/gkr/registry.go | Removed GKR registry for bls12-381 |
| ecc/bls12-377/fr/test_vector_utils/test_vector_utils.go | Removed test vector utilities for bls12-377 |
| ecc/bls12-377/fr/sumcheck/sumcheck_test.go | Removed sumcheck tests for bls12-377 |
| ecc/bls12-377/fr/sumcheck/sumcheck.go | Removed sumcheck code for bls12-377 |
| ecc/bls12-377/fr/gkr/registry.go | Removed GKR registry for bls12-377 |
| ecc/bls12-377/fr/poseidon2/gkrgates/gkrgates.go | Removed GKR gate implementations for Poseidon2 on bls12-377 |
| ecc/bls12-377/fr/gkr/registry.go | Removed additional GKR registry file for bls12-377 |
gbotrel
approved these changes
Apr 6, 2025
Collaborator
gbotrel
left a comment
gbotrel
left a comment
There was a problem hiding this comment.
so, I'm going to approve, but I think the polynomial package should only be defined in gnark-crypto and not "duplicated with different API" in gnark..
i.e. sumcheck / gkr in gnark ok, I think while we iterate on it it makes sense. But the low level stuff like polynomial should be stable enough, sturdy in gnark-crypto imo.
Contributor
Author
|
Thanks @gbotrel. Will merge once Consensys/gnark#1467 is approved. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As a proof system, it is better housed in gnark. Companion gnark PR: Consensys/gnark#1467