Closed
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR optimizes the point tripling operation for G1 and G2 Jacobian coordinates in elliptic curve cryptography, achieving 20% faster performance for bn254 and 10% for bls12-377 curves.
- Refactors the Triple method implementation with clearer step-by-step structure and improved documentation
- Adds comprehensive test coverage for the Triple method including correctness tests against double+add and benchmarking
- Implements optimized helper functions for multiplication by 3 and 4, leveraging specialized fp.MulBy3 where available
Reviewed Changes
Copilot reviewed 34 out of 34 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| internal/generator/ecc/template/point.go.tmpl | Template optimization with step-by-step algorithm and conditional MulBy3 usage |
| internal/generator/ecc/template/tests/point.go.tmpl | Template for Triple test functions and benchmarks |
| Multiple ecc/*/g1.go and g2.go files | Generated optimized Triple implementations across all curve types |
| Multiple ecc/*/g1_test.go and g2_test.go files | Generated test coverage for Triple method validation |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Optimize G1Jac tripling (20% faster for bn254, 10% for bls12-377).