Skip to content

Generate addition chains for exponentiation by fixed value in Sqrt #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gbotrel merged 16 commits into from
Nov 12, 2021
Merged

Generate addition chains for exponentiation by fixed value in Sqrt #97

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
c5fcede
feat,perf: use addchain to generate addition chains for Sqrt method
gbotrel Nov 10, 2021
4fef9be
feat: added addchain for all sqrt
gbotrel Nov 10, 2021
b1dcc5f
feat: pre-compute addition chains for Sqrt and Legendre exp functions
gbotrel Nov 11, 2021
53053f2
test: deterministic sqrt bench
gbotrel Nov 11, 2021
17c25d4
feat: added quick and dirty benchmarking script
gbotrel Nov 11, 2021
dc0c4b4
build: run go mod tidy
gbotrel Nov 11, 2021
3048245
build: gitignore generated addition chains
gbotrel Nov 11, 2021
7130328
build: tell CI to ignore non-deterministic addchain generated output
gbotrel Nov 11, 2021
02bd23a
build: fix gosec unhandled errors
gbotrel Nov 11, 2021
6d5c7db
fix: fixed exp template takes element name as parameter
gbotrel Nov 11, 2021
3dfcc4d
fix: temporaries element in addition chain back to pointers, they wil…
gbotrel Nov 11, 2021
d5f9ab4
style: code cleaning
gbotrel Nov 11, 2021
978e832
test: added property test for addchain based fixed exp
gbotrel Nov 11, 2021
0e18956
fix: fixed exp takes a value, not a pointer. also random field genera…
gbotrel Nov 11, 2021
0020165
build: aiming for determinitic addchain generation on CI
gbotrel Nov 11, 2021
b150340
fix: template used file path for doc instead of file name
gbotrel Nov 11, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ version: 2.1
jobs:
build:
docker:
- image: cimg/go:1.17.1
- image: cimg/go:1.17.3
steps:
- checkout
- run: mkdir -p /tmp/test-results
Expand All @@ -11,8 +11,8 @@ jobs:
- go-mod-v1-{{ checksum "go.sum" }}
- run: if [[ -n $(gofmt -l .) ]]; then echo "Please run gofmt"; exit 1; fi
- run: go vet -v ./...
- run: go get golang.org/x/tools/cmd/goimports
- run: go get github.com/klauspost/asmfmt/cmd/asmfmt
- run: go install golang.org/x/tools/cmd/goimports@latest
- run: go install github.com/klauspost/asmfmt/cmd/asmfmt@latest
- run: go generate ./...
- run: git update-index --assume-unchanged go.mod
- run: git update-index --assume-unchanged go.sum
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/develop.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ jobs:
- name: gosec
run: |
go install github.com/securego/gosec/cmd/gosec@latest
gosec -exclude G204 ./...
gosec -exclude="G204,G304" ./...
- name: generated files should not be modified
run: |
go generate ./...
Expand Down
2 changes: 2 additions & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
*.dll
*.so
*.dylib
*.txt

# Test binary, build with `go test -c`
*.test
Expand All @@ -29,6 +30,7 @@ tasks.txt
internal/tests/integration/
field/internal/dev.go
field/internal/dev/**
field/generator/addchain/**

.vscode

Expand Down
15 changes: 2 additions & 13 deletions ecc/bls12-377/fp/element.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading
⚡