Conversation
ivokub
requested changes
Feb 13, 2025
Collaborator
ivokub
left a comment
ivokub
left a comment
There was a problem hiding this comment.
I refactored a bit so that it would align with gnark-crypto (method names, documentation, referring to default parameters from gnark-crypto etc.).
Otherwise, looks good. I'm not so sure about the test utility for single function circuits.
Until #1422 is resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Companion to Consensys/gnark-crypto#623
This PR introduces a generic Merkle Damgard construction and uses it to instantiate Poseidon2 as a full hash function.
(Parameters only for BLS12-377)