[Coordinator] Remove redundant blob compressor interface in coordinator#2789
Open
gauravahuja wants to merge 1 commit intomainfrom
Open
[Coordinator] Remove redundant blob compressor interface in coordinator#2789gauravahuja wants to merge 1 commit intomainfrom
gauravahuja wants to merge 1 commit intomainfrom
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #2789 +/- ##
============================================
- Coverage 66.56% 66.54% -0.02%
Complexity 1631 1631
============================================
Files 625 625
Lines 23739 23729 -10
Branches 2970 2968 -2
============================================
- Hits 15801 15791 -10
- Misses 7240 7241 +1
+ Partials 698 697 -1
*This pull request uses carry forward flags. Click here to find out more.
🚀 New features to boost your workflow:
|
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements issue(s) #2638
Checklist
PR.
Note
Medium Risk
Touches blob compression/conflation sizing by replacing the coordinator-local compressor API with the external
linea.blobAPI; behavior should be equivalent but exception/size semantics now depend on the shared library implementation.Overview
Blob compression integration is refactored to drop the coordinator-defined
BlobCompressor/BlobCompressionExceptionin favor oflinea.blob.BlobCompressorandlinea.blob.BlobCompressionException.The existing Go-backed implementation is replaced with
GoBackedBlobCompressorAdapter, which wrapslinea.blob.GoBackedBlobCompressorwhile keeping coordinator metrics/logging; conflation and backtesting apps are updated to instantiate this adapter.Tests are updated/renamed to target the adapter and the fake compressor now implements the shared interface (including
versionandcompressedSize).Reviewed by Cursor Bugbot for commit 9600efd. Bugbot is set up for automated code reviews on this repo. Configure here.