Skip to content

[Coordinator] Remove redundant blob compressor interface in coordinator#2789

Open
gauravahuja wants to merge 1 commit intomainfrom
gauravahuja/remove_coordinator_compressor_interface
Open

[Coordinator] Remove redundant blob compressor interface in coordinator#2789
gauravahuja wants to merge 1 commit intomainfrom
gauravahuja/remove_coordinator_compressor_interface

Conversation

@gauravahuja
Copy link
Copy Markdown
Contributor

@gauravahuja gauravahuja commented Apr 10, 2026

This PR implements issue(s) #2638

Checklist

  • I wrote new tests for my new core changes.
  • I have successfully ran tests, style checker and build against my new changes locally.
  • If this change is deployed to any environment (including Devnet), E2E test coverage exists or is included in this
    PR.
  • I have informed the team of any breaking changes if there are any.

Note

Medium Risk
Touches blob compression/conflation sizing by replacing the coordinator-local compressor API with the external linea.blob API; behavior should be equivalent but exception/size semantics now depend on the shared library implementation.

Overview
Blob compression integration is refactored to drop the coordinator-defined BlobCompressor/BlobCompressionException in favor of linea.blob.BlobCompressor and linea.blob.BlobCompressionException.

The existing Go-backed implementation is replaced with GoBackedBlobCompressorAdapter, which wraps linea.blob.GoBackedBlobCompressor while keeping coordinator metrics/logging; conflation and backtesting apps are updated to instantiate this adapter.

Tests are updated/renamed to target the adapter and the fake compressor now implements the shared interface (including version and compressedSize).

Reviewed by Cursor Bugbot for commit 9600efd. Bugbot is set up for automated code reviews on this repo. Configure here.

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 82.60870% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 66.54%. Comparing base (5e5bc85) to head (9600efd).

Files with missing lines Patch % Lines
...zkevm/ethereum/coordination/blob/BlobCompressor.kt 90.47% 2 Missing ⚠️
.../zkevm/coordinator/app/conflation/ConflationApp.kt 0.00% 1 Missing ⚠️
.../conflationbacktesting/ConflationBacktestingApp.kt 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2789      +/-   ##
============================================
- Coverage     66.56%   66.54%   -0.02%     
  Complexity     1631     1631              
============================================
  Files           625      625              
  Lines         23739    23729      -10     
  Branches       2970     2968       -2     
============================================
- Hits          15801    15791      -10     
- Misses         7240     7241       +1     
+ Partials        698      697       -1     
Flag Coverage Δ *Carryforward flag
hardhat 95.90% <ø> (ø) Carriedforward from 5e5bc85
kotlin 54.39% <82.60%> (-0.03%) ⬇️
lido-governance-monitor 97.60% <ø> (ø) Carriedforward from 5e5bc85
linea-native-libs 90.69% <ø> (ø) Carriedforward from 5e5bc85
linea-shared-utils 97.22% <ø> (ø) Carriedforward from 5e5bc85
native-yield-automation-service 97.68% <ø> (ø) Carriedforward from 5e5bc85
postman 100.00% <ø> (ø) Carriedforward from 5e5bc85
sdk-core 98.01% <ø> (ø) Carriedforward from 5e5bc85
sdk-ethers 89.83% <ø> (ø) Carriedforward from 5e5bc85
sdk-viem 99.45% <ø> (ø) Carriedforward from 5e5bc85

*This pull request uses carry forward flags. Click here to find out more.

Files with missing lines Coverage Δ
...conflation/ConflationCalculatorByDataCompressed.kt 95.74% <ø> (ø)
.../zkevm/coordinator/app/conflation/ConflationApp.kt 0.00% <0.00%> (ø)
.../conflationbacktesting/ConflationBacktestingApp.kt 9.78% <0.00%> (ø)
...zkevm/ethereum/coordination/blob/BlobCompressor.kt 92.77% <90.47%> (-0.78%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants