Fix charge validation, bare excepts, and docstring error#9
Open
MichaelLod wants to merge 1 commit intoCortical-Labs:mainfrom
Open
Fix charge validation, bare excepts, and docstring error#9MichaelLod wants to merge 1 commit intoCortical-Labs:mainfrom
MichaelLod wants to merge 1 commit intoCortical-Labs:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Three small fixes across the SDK:
1. Charge injection validation now checks absolute value (
src/cl/__init__.py)StimDesign._validateonly checkedcharge_pC > limit, so a cathodic (negative current) phase could bypass the 3.0 nC safety limit. For example,-3.0 uA × 1200 us = -3.6 nCwould pass the check despite exceeding the charge injection limit. Changed toabs(charge_pC) > limit.2. Bare
except:replaced withexcept Exception:(_criticality.py,_functional_connectivity.py)Bare
except:catchesKeyboardInterrupt,SystemExit, andGeneratorExitin addition to regular exceptions. This can mask issues during long-running analysis and prevent users from interrupting stuck computations.3. Copy-paste docstring fix (
_information_entropy.py)_analyse_information_entropydocstring referencedanalyse_lempel_ziv_complexity()instead ofanalyse_information_entropy().