Conversation
Contributor
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
📝 WalkthroughWalkthroughUpdated Simplified Chinese (zh-rCN) string resources: revised attachment and notes pluralization, pinning terminology, auto-sort and date/time labels, added import-related strings for Notally/Quillpad, and adjusted notification permission phrasing. One resource file modified (+17 / -14). Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Possibly related issues
Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 3
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@app/src/main/res/values-zh-rCN/strings.xml`:
- Line 21: The string resource attach_file currently uses the noun phrase
“附件文件”; update its value to a verb/action form used for the UI action (e.g.,
“添加附件” or “附加文件”) so it reads as “Attach file” in Chinese; edit the <string
name="attach_file"> entry in strings.xml accordingly and verify the exact chosen
wording against the source spreadsheet referenced in issue `#993`.
- Around line 372-374: The three string resources are shifted: update the values
so name="time" has "时间", name="time_24h" has "24 小时", and name="time_am_pm" has
"上午/下午" (or the exact wording from the translations.xlsx spreadsheet referenced
in `#993`); edit the entries for time, time_24h, and time_am_pm to realign each
key with its correct Simplified Chinese value.
- Around line 296-298: The translations inconsistent: "pin" ("置于顶部") and
"pinned" ("已置顶") use 置顶 while "unpin" remains "取消固定"; update the string resource
named "unpin" to use the matching 置顶 term (e.g., "取消置顶") so the verb is
consistent with "pin"/"pinned" while leaving "pin_to_status_bar" and
"unpin_from_status_bar" as-is because those refer to status-bar notifications.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 02eaef84-557b-46b3-9da4-06eeab0e5d9e
⛔ Files ignored due to path filters (1)
app/translations.xlsxis excluded by!**/*.xlsx
📒 Files selected for processing (1)
app/src/main/res/values-zh-rCN/strings.xml
Comment on lines
+372
to
+374
| <string name="time">使用系统壁纸颜色</string> | ||
| <string name="time_24h">时间</string> | ||
| <string name="time_am_pm">24 小时</string> |
Contributor
There was a problem hiding this comment.
Translation values appear shifted by one row — time, time_24h, and time_am_pm are all mis-translated.
Comparing with the surrounding entries:
- Line 371
theme_use_dynamic_colors= “使用系统的壁纸颜色” (Use system wallpaper colors) ✅ - Line 372
time= “使用系统壁纸颜色” ❌ — this is essentially a duplicate of the dynamic-colors string; should be “时间” (Time). - Line 373
time_24h= “时间” ❌ — this is the value that belongs totime; should be “24 小时” (24-hour). - Line 374
time_am_pm= “24 小时” ❌ — this is the value that belongs totime_24h; should be “上午/下午” (AM/PM).
As a result the date/time format settings UI will display nonsensical labels (e.g. the “Time” label will read “Use system wallpaper colors”, the AM/PM toggle will read “24 hours”). Please re-align these three values with their keys.
🐛 Proposed fix
- <string name="time">使用系统壁纸颜色</string>
- <string name="time_24h">时间</string>
- <string name="time_am_pm">24 小时</string>
+ <string name="time">时间</string>
+ <string name="time_24h">24 小时</string>
+ <string name="time_am_pm">上午/下午</string>Please verify the intended Simplified Chinese wording for time_am_pm against the source spreadsheet (translations.xlsx) referenced in #993 — “上午/下午” is the conventional rendering, but the spreadsheet may specify something different.
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| <string name="time">使用系统壁纸颜色</string> | |
| <string name="time_24h">时间</string> | |
| <string name="time_am_pm">24 小时</string> | |
| <string name="time">时间</string> | |
| <string name="time_24h">24 小时</string> | |
| <string name="time_am_pm">上午/下午</string> |
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@app/src/main/res/values-zh-rCN/strings.xml` around lines 372 - 374, The three
string resources are shifted: update the values so name="time" has "时间",
name="time_24h" has "24 小时", and name="time_am_pm" has "上午/下午" (or the exact
wording from the translations.xlsx spreadsheet referenced in `#993`); edit the
entries for time, time_24h, and time_am_pm to realign each key with its correct
Simplified Chinese value.
Crustack
force-pushed
the
translation/update
branch
from
46e253d to
9e207a7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #993
Summary by CodeRabbit