DD-1783: accidentally touching "Host Dataverse"

[jo-pol]

IQSS#11301

What this PR does / why we need it:

Which issue(s) this PR closes:

• Closes #

Special notes for your reviewer:

See also IQSS#11301 (review)

Rephrased by mail:

If I have a “test” collection and I create a dataset in it, the host collection starts as “test”. If I edit/delete there, it used to cause a null pointer (if I understand) but now, with your change, will default to the “root” collection. If I try to save that dataset, and don’t have permissions to create a dataset in the “root” collection (say I only have permissions to create one in the “test” collection), what happens? I assume it would fail. (If not, it would be worse if I actually can create a dataset in root this way).

My suggestion was that it might be more robust to treat a null as invalid and not change the host dataverse from what it was (versus defaulting to root). I haven’t tried to do this, so my suggestion of just not updating in the DatasetPage code might not work.

Suggestions on how to test this:

In a dataversenl environment, or add dataverses to a VM

1. In the user interface click Add Data → New Dataset
2. The cursor is placed in the “Host Dataverse” field.
3. Quickly type: space, back-space, tab
4. Fill in the required fields and click Save.

Fine logging of DataverseConverter will show the name of the initial dataverse.

Does this PR introduce a user interface change? If mockups are available, please link/include them here:

Is there a release notes update needed for this change?:

Additional documentation:

[janvanmansum]

As discussed with @aliassheikh this change does not seem to be necessary for the DANS specific code. Therefore, it has not been incorporated into v6.5-DANS-DataStation. Closing this PR.