Corrige le problème des URL avec des espaces à l'intérieur#623
Merged
bellangerq merged 4 commits intomainfrom Feb 2, 2024
Hidden character warning
The head ref may contain hidden characters: "622-les-espaces-dans-les-urls-des-pages-emp\u00eachent-la-cr\u00e9ation-daudit"
Merged
Conversation
✅ Deploy Preview for confiture ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Collaborator
|
Alors effectivement, si on encode le champs URL, on va pouvoir mettre n'importe quoi dedans. Mais je pense que le problème est plutôt du côté de la validation native du navigateur qui accepte des URLs erronées. Perso, je suis plus de l'avis de fixer cette validation plutôt que d'accepter des URLs qui ne fonctionneront pas quand on les affichera sur l'audit/le rapport. On pourrait utiliser un attribut |
hissalht
approved these changes
Jan 25, 2024
68fe409 to
2686bb0
Compare
hissalht
approved these changes
Jan 31, 2024
b059239 to
5406837
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #622