fix(vmm): do not wait for tap device to be created

[ThomasRubini]

Summary by CodeRabbit

• Refactor
  • Improved VM startup synchronization and error handling mechanisms for enhanced reliability.

[coderabbitai]

Caution

Review failed

Pull request was closed or merged during review

📝 Walkthrough

Walkthrough

The change consolidates multiple IPC channels used during VM startup into a single vm_setup channel that communicates either a successful setup with the stop-handle or an error, replacing separate error and stop-handle channels throughout the startup sequence.

Changes

Cohort / File(s)	Summary
VM Startup Channel Consolidation backend/src/vm_lifecycle.rs	Replaced multiple IPC channels for VM setup with a single vm_setup channel transmitting Result<Arc<AtomicBool>, VmError>. Error propagation for VMM creation, network setup, and configuration failures now flows through this unified channel. Removed related conditional blocks and stop-handle channel references, resulting in net code reduction.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

• feat: Implement full application flow #66 — Also modifies backend/src/vm_lifecycle.rs and adjusts the VM startup/stop-handle IPC flow for error propagation and handle communication.

Suggested labels

vmm, backend

Suggested reviewers

• jorisvilardell

Poem

🐰 One channel now flows where many once split,
Errors and handles in a single bit,
VM startup syncs with grace and care,
Simpler paths float through the air! 🌟

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Title check	⚠️ Warning	The title 'fix(vmm): do not wait for tap device to be created' is misleading. The raw summary shows the main change is replacing multiple IPC channels with a single vm_setup channel for error propagation and stop-handle communication, not avoiding waiting for tap device creation.	Update the title to accurately reflect the primary change, such as 'refactor(vmm): consolidate VM setup error handling into single channel' or 'refactor(vmm): unify VM startup communication with single channel'.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

• 📝 Generate docstrings (stacked PR)
• 📝 Generate docstrings (commit on current branch)

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch vmm_do_not_wait_for_tap

📝 Coding Plan

• Generate coding plan for human review comments

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

Tip

CodeRabbit can generate a title for your PR based on the changes with custom instructions.

Set the reviews.auto_title_instructions setting to generate a title for your PR based on the changes in the PR with custom instructions.

[Proxyfil]

LGTM