This repository was archived by the owner on Sep 8, 2021. It is now read-only.
Fixes #118 : Drag and drop multi-uploads#124
Merged
artlowel merged 6 commits intoDSpace-Labs:masterfrom May 27, 2016
Merged
Conversation
| * @param options | ||
| * FileUploader options to pass to default FileUploader | ||
| */ | ||
| constructor(private translate: TranslateService, |
Contributor
There was a problem hiding this comment.
TranslateService is not necessary here it seems, or are you planning to use it later?
Member
Author
There was a problem hiding this comment.
Yes, actually. Looks like I forgot to take care of the TODO statements lower in this file where I noted that I should be using i18n. That's why TranslateService was added ;) Thanks for the reminder
Member
Author
There was a problem hiding this comment.
Just fixed this in a new commit. TranslateService is now being used to provide i18n to error notifications
tdonohue
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This feature uses
ng2-file-uploadto create a drag and drop file upload experience.ng2-file-uploadmanages the upload queue and the upload process.It replaces our existing file upload button with a drag-and-drop 'zone' or button option. Either can be used to select multiple files at one time.
Also provides an upload progress bar when the Item Create form is submitted, letting users know the status of the file uploads.
NOTE: There is a known issue in
ng2-file-uploadregarding uploading files to our REST API. Unfortunately our REST API doesn't yet support multipart forms, and therefore may corrupt some file formats on upload (especially images). See valor-software/ng2-file-upload#223. I've already submitted a proposed fix tong2-file-upload: valor-software/ng2-file-upload#224However, I have discovered this exact same upload issue exists in our current file upload code (which also uses multipart forms with our REST API).