Revert 4 dargon789 patch 1

[Dargon789]

Summary of the Pull Request

References and Relevant Issues

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

PR Checklist

• Closes #xxx
• Tests added/passed
• Documentation updated
  • If checked, please file a pull request on our docs repo and link it here: #xxx
• Schema updated (if necessary)

Summary by Sourcery

Update package publishing pipeline and add a basic CircleCI configuration.

Build:

• Restore NuGet packages before running the winget publishing step to ensure dependencies are available.

CI:

• Introduce an initial CircleCI configuration with a placeholder job and workflow that runs a simple hello-world command.

[sourcery-ai]

Reviewer's Guide

This PR updates CI configuration by adding a NuGet restore step to the existing GitHub Actions winget publish workflow and introduces a basic CircleCI pipeline configuration, without modifying application code.

Sequence diagram for updated GitHub Actions winget publish workflow

sequenceDiagram
    actor Maintainer
    participant GitHub
    participant GitHubActions
    participant PublishJob
    participant NuGetOrg
    participant WingetCreateExe

    Maintainer->>GitHub: Publish release (Stable or Preview)
    GitHub-->>GitHubActions: release event
    GitHubActions->>PublishJob: Start publish job

    PublishJob->>PublishJob: Checkout repository (implicit)
    PublishJob->>NuGetOrg: dotnet restore --source https://api.nuget.org/v3/index.json
    NuGetOrg-->>PublishJob: Restore packages

    PublishJob->>PublishJob: Select relevant asset and version
    PublishJob->>GitHub: Download wingetcreate latest (curl.exe)
    PublishJob->>WingetCreateExe: Execute wingetcreate update
    WingetCreateExe-->>PublishJob: winget package updated
    PublishJob-->>GitHubActions: Job completed
    GitHubActions-->>Maintainer: Publish workflow completed

Loading

Flow diagram for new CircleCI say-hello pipeline

flowchart LR
    A[Code_push_or_pipeline_trigger] --> B[CircleCI_load_config_yml]
    B --> C[Job_say_hello_start_docker_executor_cimg_base_current]
    C --> D[Step_checkout_repository]
    D --> E[Step_run_echo_Hello_World]
    E --> F[Job_say_hello_complete]
    F --> G[Workflow_say_hello_workflow_complete]

Loading

File-Level Changes

Change	Details	Files
Add a NuGet restore step to the winget GitHub Actions workflow before publishing Windows Terminal artifacts.	Insert a step named 'Restore NuGet packages' in the winget workflow job. Run 'dotnet restore' against NuGet.org prior to the publish step to ensure dependencies are available. Leave the existing publish and wingetcreate update logic unchanged.	.github/workflows/winget.yml
Introduce a starter CircleCI configuration defining a simple 'say-hello' job and workflow.	Create a CircleCI config using version 2.1 of the pipeline engine. Define a docker-based 'say-hello' job that checks out code and echoes a greeting. Configure a workflow that runs the 'say-hello' job.	.circleci/config.yml

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[gemini-code-assist]

Summary of Changes

Hello @Dargon789, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces new continuous integration capabilities by adding a CircleCI configuration and updates a key NuGet package dependency. While the title suggests a revert, the changes observed in the patch are additive and modificatory, establishing a basic CI pipeline and updating project dependencies.

Highlights

• CircleCI Integration: A new .circleci/config.yml file was added, introducing a basic CircleCI pipeline with a "say-hello" job that prints "Hello, World!".
• NuGet Dependency Update: The .nuget/packages.config file was modified to replace the vswhere package with NETStandard.Library version 2.0.3.
• Discrepancy with Title: Despite the pull request title "Revert 4 dargon789 patch 1", the actual changes introduce new files and modify existing ones, rather than reverting previous changes.

Changelog

• .circleci/config.yml
  • Added a new CircleCI configuration file.
  • Configured a "say-hello" job using the cimg/base:current Docker image.
  • Defined a workflow to run the "say-hello" job.
• .nuget/packages.config
  • Replaced the vswhere package with NETStandard.Library version 2.0.3.

Ignored Files

• Ignored by pattern: .github/workflows/** (1)
  • .github/workflows/winget.yml

Activity

• No human activity has been recorded on this pull request yet.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[snyk-io]

✅ Snyk checks have passed. No issues have been found so far.

Status	Scanner	Critical	High	Medium	Low	Total (0)
✅	Open Source Security	0	0	0	0	0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

[github-actions]

@check-spelling-bot Report

🔴 Please review

See the 📂 files view, the 📜action log, or 📝 job summary for details.

Unrecognized words (2)

cimg
circleci

To accept these unrecognized words as correct, you could run the following commands

... in a clone of the git@github.com:Dargon789/terminal.git repository
on the revert-4-Dargon789-patch-1 branch (ℹ️ how do I use this?):

curl -s -S -L 'https://raw.githubusercontent.com/check-spelling/check-spelling/v0.0.25/apply.pl' |
perl - 'https://github.com/Dargon789/terminal/actions/runs/22083534876/attempts/1' &&
git commit -m 'Update check-spelling metadata'

OR

To have the bot accept them for you, comment in the PR quoting the following line:
@check-spelling-bot apply updates.

Pattern suggestions ✂️ (1)

You could add these patterns to .github/actions/spelling/patterns/83b9569ce0393f2de99ffa5ea17fdc869e699090.txt:

# Automatically suggested patterns

# hit-count: 1 file-count: 1
# container images
image: [-\w./:@]+

Alternatively, if a pattern suggestion doesn't make sense for this project, add a #
to the beginning of the line in the candidates file with the pattern to stop suggesting it.

Errors, Warnings, and Notices ❌ (3)

See the 📂 files view, the 📜action log, or 📝 job summary for details.

❌ Errors, Warnings, and Notices	Count
ℹ️ candidate-pattern	1
❌ check-file-path	1
⚠️ ignored-expect-variant	1

See ❌ Event descriptions for more information.

✏️ Contributor please read this

By default the command suggestion will generate a file named based on your commit. That's generally ok as long as you add the file to your commit. Someone can reorganize it later.

If the listed items are:

• ... misspelled, then please correct them instead of using the command.
• ... names, please add them to .github/actions/spelling/allow/names.txt.
• ... APIs, you can add them to a file in .github/actions/spelling/allow/.
• ... just things you're using, please add them to an appropriate file in .github/actions/spelling/expect/.
• ... tokens you only need in one place and shouldn't generally be used, you can add an item in an appropriate file in .github/actions/spelling/patterns/.

See the README.md in each directory for more information.

🔬 You can test your commits without appending to a PR by creating a new branch with that extra change and pushing it to your fork. The check-spelling action will run in response to your push -- it doesn't require an open pull request. By using such a branch, you can limit the number of typos your peers see you make. 😉

If the flagged items are 🤯 false positives

If items relate to a ...

• binary file (or some other file you wouldn't want to check at all).

  Please add a file path to the excludes.txt file matching the containing file.

  File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.

  ^ refers to the file's path from the root of the repository, so ^README\.md$ would exclude README.md (on whichever branch you're using).

• well-formed pattern.

  If you can write a pattern that would match it,
  try adding it to the patterns.txt file.

  Patterns are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your lines.

  Note that patterns can't match multiline strings.

[gemini-code-assist]

Code Review

The pull request introduces a placeholder CircleCI configuration and an incorrect change to the NuGet package configuration. The CircleCI setup lacks the publishing logic mentioned in the PR description. Additionally, replacing the vswhere tool with the NETStandard.Library package in .nuget/packages.config is likely a mistake, as these serve entirely different purposes in the build environment. These changes do not appear to align with the stated goal of updating the package publishing pipeline.

I am having trouble creating individual review comments. Click here to see my feedback.

.nuget/packages.config (3)

Replacing vswhere with NETStandard.Library in this configuration file appears to be incorrect. vswhere is a tool used to locate Visual Studio installations, which is often required by build scripts. NETStandard.Library is a development dependency usually managed within project files. Additionally, this file is not referenced in the provided Azure DevOps pipeline templates, suggesting it may be misplaced or a regression.

  <package id="vswhere" version="2.6.7" />

.circleci/config.yml (21-23)

This CircleCI job is a placeholder that only echoes 'Hello, World!'. It should be updated to include actual build or publishing logic as described in the PR summary, or removed to avoid adding unnecessary files to the repository.