[e2e] bump test-infra

[pducolin]

What does this PR do?

Bump test-infra-definitions in new-e2e module

Changelog: DataDog/test-infra-definitions@6dbc5da...eb67dd1

Motivation

Among the changes there is an improvement in curl error handling that should reduce and give more insights on installer issues we see in e2e tests

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

[pr-commenter]

Bloop Bleep... Dogbot Here

Regression Detector Results

Run ID: 21853bb2-46eb-43d1-8786-eda327b2a5bc
Baseline: 1c2ad36
Comparison: afcbc44

Performance changes are noted in the perf column of each table:

• ✅ = significantly better comparison variant performance
• ❌ = significantly worse comparison variant performance
• ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf	experiment	goal	Δ mean %	Δ mean % CI
➖	file_to_blackhole	% cpu utilization	+0.32	[-6.07, +6.70]

Fine details of change detection per experiment

perf	experiment	goal	Δ mean %	Δ mean % CI
➖	uds_dogstatsd_to_api_cpu	% cpu utilization	+2.22	[-0.50, +4.94]
➖	file_to_blackhole	% cpu utilization	+0.32	[-6.07, +6.70]
➖	basic_py_check	% cpu utilization	+0.30	[-1.98, +2.58]
➖	process_agent_standard_check_with_stats	memory utilization	+0.26	[+0.23, +0.29]
➖	tcp_syslog_to_blackhole	ingress throughput	+0.24	[+0.15, +0.32]
➖	process_agent_standard_check	memory utilization	+0.13	[+0.10, +0.17]
➖	process_agent_real_time_mode	memory utilization	+0.04	[+0.01, +0.08]
➖	tcp_dd_logs_filter_exclude	ingress throughput	+0.02	[-0.00, +0.04]
➖	uds_dogstatsd_to_api	ingress throughput	-0.00	[-0.20, +0.20]
➖	trace_agent_json	ingress throughput	-0.00	[-0.03, +0.03]
➖	trace_agent_msgpack	ingress throughput	-0.01	[-0.02, +0.00]
➖	idle	memory utilization	-0.12	[-0.16, -0.08]
➖	otel_to_otel_logs	ingress throughput	-0.26	[-0.71, +0.19]
➖	file_tree	memory utilization	-0.51	[-0.60, -0.42]
➖	pycheck_1000_100byte_tags	% cpu utilization	-1.07	[-6.05, +3.92]

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

3. Its configuration does not mark it "erratic".

[pducolin]

/merge

[dd-devflow]

🚂 MergeQueue

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

Use /merge -c to cancel this operation!

[moth-a]

One small, non-blocking request. Otherwise lgtm, thanks for the fixes!!

[dd-devflow]

⚠️ MergeQueue

This merge request was unqueued

If you need support, contact us on Slack #ci-interfaces!

[chouetz]

Only minor comments, LGTM

[chouetz]

I guess assert.NoError will raise a message so no need to create one here, correct?

[pducolin]

It would not: assert does not interrupt the go routine execution. I should use require that calls FailNow, but currently it panics and interrupts the Eventually. This will change as soon as testify merges this PR

[chouetz]

As a consequence we might have put a log message to understand the error. But it's unlikely to happen so I guess it's fine

[pducolin]

I think we log the error out of the Eventually. All failed assertions messages are saved in the assert.CollectT and logged on Fail

https://github.com/marshall-lee/testify/blob/master/assert/assertions.go#L312-L336

[pducolin]

/merge

[dd-devflow]

🚂 MergeQueue

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

Use /merge -c to cancel this operation!

[dd-devflow]

🚂 MergeQueue

Added to the queue.

This build is going to start soon! (estimated merge in less than 26m)

Use /merge -c to cancel this operation!