Update testify to 1.10.0#31520
Conversation
Go Package Import DifferencesBaseline: 6686f4d
|
Regression DetectorRegression Detector ResultsMetrics dashboard Baseline: 6686f4d Optimization Goals: ❌ Significant changes detected
|
| perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
|---|---|---|---|---|---|---|
| ❌ | pycheck_lots_of_tags | % cpu utilization | +6.88 | [+3.26, +10.51] | 1 | Logs |
| ➖ | uds_dogstatsd_to_api_cpu | % cpu utilization | +0.42 | [-0.31, +1.15] | 1 | Logs |
| ➖ | otel_to_otel_logs | ingress throughput | +0.40 | [-0.24, +1.05] | 1 | Logs |
| ➖ | quality_gate_idle_all_features | memory utilization | +0.34 | [+0.24, +0.43] | 1 | Logs bounds checks dashboard |
| ➖ | file_to_blackhole_100ms_latency | egress throughput | +0.08 | [-0.67, +0.83] | 1 | Logs |
| ➖ | file_to_blackhole_0ms_latency | egress throughput | +0.05 | [-0.77, +0.87] | 1 | Logs |
| ➖ | file_to_blackhole_500ms_latency | egress throughput | +0.03 | [-0.74, +0.80] | 1 | Logs |
| ➖ | tcp_dd_logs_filter_exclude | ingress throughput | +0.00 | [-0.01, +0.01] | 1 | Logs |
| ➖ | uds_dogstatsd_to_api | ingress throughput | -0.00 | [-0.10, +0.09] | 1 | Logs |
| ➖ | file_to_blackhole_1000ms_latency_linear_load | egress throughput | -0.22 | [-0.68, +0.25] | 1 | Logs |
| ➖ | file_to_blackhole_1000ms_latency | egress throughput | -0.33 | [-1.09, +0.44] | 1 | Logs |
| ➖ | file_to_blackhole_300ms_latency | egress throughput | -0.33 | [-0.96, +0.30] | 1 | Logs |
| ➖ | file_tree | memory utilization | -0.38 | [-0.52, -0.24] | 1 | Logs |
| ➖ | tcp_syslog_to_blackhole | ingress throughput | -0.49 | [-0.54, -0.43] | 1 | Logs |
| ➖ | quality_gate_idle | memory utilization | -0.50 | [-0.54, -0.45] | 1 | Logs bounds checks dashboard |
| ➖ | basic_py_check | % cpu utilization | -1.20 | [-4.98, +2.58] | 1 | Logs |
Bounds Checks: ❌ Failed
| perf | experiment | bounds_check_name | replicates_passed | links |
|---|---|---|---|---|
| ❌ | file_to_blackhole_0ms_latency | lost_bytes | 9/10 | |
| ✅ | file_to_blackhole_0ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_1000ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_1000ms_latency_linear_load | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_100ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_100ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_300ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_300ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_500ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_500ms_latency | memory_usage | 10/10 | |
| ✅ | quality_gate_idle | memory_usage | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_idle_all_features | memory_usage | 10/10 | bounds checks dashboard |
Explanation
Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%
Performance changes are noted in the perf column of each table:
- ✅ = significantly better comparison variant performance
- ❌ = significantly worse comparison variant performance
- ➖ = no significant change in performance
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
CI Pass/Fail Decision
✅ Passed. All Quality Gates passed.
- quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
Test changes on VMUse this command from test-infra-definitions to manually test this PR changes on a VM: inv create-vm --pipeline-id=50064993 --os-family=ubuntuNote: This applies to commit d44ed3a |
misteriaud
left a comment
There was a problem hiding this comment.
So nice to be able to use require in EventuallyWithT 🎉
|
/merge |
Devflow running:
|
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-7.61.x 7.61.x
# Navigate to the new working tree
cd .worktrees/backport-7.61.x
# Create a new branch
git switch --create backport-31520-to-7.61.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 ad40689b877dbf92b7144518f46d2a8f55f29e2e
# Push it to GitHub
git push --set-upstream origin backport-31520-to-7.61.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-7.61.xThen, create a pull request where the |
(cherry picked from commit ad40689)
(cherry picked from commit ad40689)
What does this PR do?
Update
testifyto the latest (1.10.0)Motivation
Benefit from stretchr/testify#1481 to be able to use
requireinEventuallyDescribe how to test/QA your changes
Covered by CI (this is a test dependency)
Possible Drawbacks / Trade-offs
Additional Notes