Merged
Conversation
* don't return from profilesToApply on DAP status update * add/remove some logging,log uuid * cleanup * remove one more log line * revert datadogagentinternal controller change
khewonc
approved these changes
Oct 16, 2025
Codecov Report❌ Patch coverage is
❌ Your patch status has failed because the patch coverage (70.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #2242 +/- ##
==========================================
+ Coverage 39.08% 39.10% +0.01%
==========================================
Files 254 254
Lines 26307 26322 +15
==========================================
+ Hits 10282 10293 +11
- Misses 15412 15415 +3
- Partials 613 614 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
dd-octo-sts bot
pushed a commit
that referenced
this pull request
Oct 16, 2025
* Attempt to fix spurrious DS cleanups * don't return from profilesToApply on DAP status update (#2240) * don't return from profilesToApply on DAP status update * add/remove some logging,log uuid * cleanup * remove one more log line * revert datadogagentinternal controller change --------- Co-authored-by: Timothée Bavelier <timothee.bavelier@datadoghq.com> (cherry picked from commit 686a1db)
2 tasks
levan-m
added a commit
that referenced
this pull request
Oct 16, 2025
* Attempt to fix spurrious DS cleanups * don't return from profilesToApply on DAP status update (#2240) * don't return from profilesToApply on DAP status update * add/remove some logging,log uuid * cleanup * remove one more log line * revert datadogagentinternal controller change --------- (cherry picked from commit 686a1db) Co-authored-by: levan-m <116471169+levan-m@users.noreply.github.com> Co-authored-by: Timothée Bavelier <timothee.bavelier@datadoghq.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Debugging + add safeguard to avoid cleaning DS if no valid are found
Same as #2239 opened against main branch.
Motivation
What inspired you to submit this pull request?
Additional Notes
Anything else we should know when reviewing?
Minimum Agent Versions
Are there minimum versions of the Datadog Agent and/or Cluster Agent required?
Describe your test plan
Write there any instructions and details you may have to test your PR.
Checklist
bug,enhancement,refactoring,documentation,tooling, and/ordependenciesqa/skip-qalabel