Merged
Conversation
added 2 commits
July 19, 2023 18:56
Contributor
Overall package sizeSelf size: 4.91 MB Dependency sizes
🤖 This report was automatically generated by heaviest-objects-in-the-universe |
Codecov Report
@@ Coverage Diff @@
## master #3419 +/- ##
==========================================
+ Coverage 84.25% 84.28% +0.03%
==========================================
Files 214 214
Lines 8392 8402 +10
Branches 33 33
==========================================
+ Hits 7071 7082 +11
+ Misses 1321 1320 -1
... and 4 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
tlhunter
approved these changes
Jul 19, 2023
Qard
approved these changes
Jul 20, 2023
szegedi
pushed a commit
that referenced
this pull request
Jul 20, 2023
* address and fix edge cases * move to better tracer option name for service name flattening
Merged
szegedi
pushed a commit
that referenced
this pull request
Jul 20, 2023
* address and fix edge cases * move to better tracer option name for service name flattening
Merged
szegedi
pushed a commit
that referenced
this pull request
Jul 20, 2023
* address and fix edge cases * move to better tracer option name for service name flattening
tlhunter
pushed a commit
that referenced
this pull request
Jul 21, 2023
* address and fix edge cases * move to better tracer option name for service name flattening
tlhunter
pushed a commit
that referenced
this pull request
Jul 21, 2023
* address and fix edge cases * move to better tracer option name for service name flattening
tlhunter
pushed a commit
that referenced
this pull request
Jul 21, 2023
* address and fix edge cases * move to better tracer option name for service name flattening
Member
|
This is missing the typescript definition for the additional config property |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Defaults and computation for service representation (mostly peer service flag) were missing tests and had unaccounted for edge cases.