Conversation
Co-authored-by: juan-fernandez <22798219+juan-fernandez@users.noreply.github.com>
|
Bits Dev status: ✅ Done Comment @DataDog to request changes |
|
I can only run on private repositories. |
Overall package sizeSelf size: 5.56 MB Dependency sizes| name | version | self size | total size | |------|---------|-----------|------------| | import-in-the-middle | 3.0.1 | 82.56 kB | 817.39 kB | | dc-polyfill | 0.1.10 | 26.73 kB | 26.73 kB |🤖 This report was automatically generated by heaviest-objects-in-the-universe |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #8078 +/- ##
==========================================
- Coverage 73.77% 73.74% -0.04%
==========================================
Files 782 782
Lines 36339 36354 +15
==========================================
- Hits 26809 26808 -1
- Misses 9530 9546 +16 Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
✨ Fix all issues with BitsAI or with Cursor
|
BenchmarksBenchmark execution time: 2026-04-23 12:48:34 Comparing candidate commit 4a3bf8b in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 1343 metrics, 101 unstable metrics. |
BridgeAR
left a comment
BridgeAR
left a comment
There was a problem hiding this comment.
I can see that this fixes the immediate issue.
I believe it just causes a new issue, which is that the version would not automatically be updated anymore and we would for example not receive the latest security updates and dependabot would also not know to update this.
What about changing junit-upload-github-action to use a specific pinned version, if not specified and we just update that each time there is a new CI release with that version being the new default. That way the benefit would also exist for our users the same as for us :)
Co-authored-by: juan-fernandez <22798219+juan-fernandez@users.noreply.github.com>
2 participants
What does this PR do?
Pins the
datadog-ci versionused byDataDog/junit-upload-github-actionto 5.13.1 in.github/actions/push_to_test_optimization/action.yml and .github/workflows/platform.yml.Motivation
Some jobs intermittently fail in the
push_to_test_optimizationstep after the upgrade toDataDog/junit-upload-github-actionv3.0.0. Example in https://github.com/DataDog/dd-trace-js/actions/runs/24780644771/job/72510523178?pr=8060.The failure happens inside
DataDog/install-datadog-ci-github-actionwhile resolving the floatingdatadog-civersion v5, wherejqreceives a non-release JSON payload and crashes withCannot index string with string "prerelease". Pinningdatadog-cito 5.13.1 avoids that floating-version GitHub release lookup while preserving the v3 junit upload action behavior.