Skip to content

Add metric_patterns options to filter all metric submission with a list of regexes#11695

Merged
sarah-witt merged 14 commits intomasterfrom
sarah/metrics-pattern-docs
Mar 18, 2022
Merged

Add metric_patterns options to filter all metric submission with a list of regexes#11695
sarah-witt merged 14 commits intomasterfrom
sarah/metrics-pattern-docs

Conversation

@sarah-witt
Copy link
Copy Markdown
Contributor

@sarah-witt sarah-witt commented Mar 17, 2022

What does this PR do?

Documents the metric_patterns config option and bumps the base check requirement for all integrations that can use it

Motivation

We added a new option to the base check in #11508, and it needs to be documented in all agent-based checks.

Additional Notes

depends on #11696 which adds the option to the base template

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached

@github-actions
Copy link
Copy Markdown
Contributor

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

@github-actions
Copy link
Copy Markdown
Contributor

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 17, 2022

Codecov Report

Merging #11695 (0f7942e) into master (1314a92) will not change coverage.
The diff coverage is n/a.

Flag Coverage Δ
activemq_xml 82.31% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@sarah-witt sarah-witt changed the title Document metric_patterns config option and bump base check requirement Add metric_patterns options to filter all metric submission with a list of regexes Mar 17, 2022
@sarah-witt
Copy link
Copy Markdown
Contributor Author

/azp run PR All Comment

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@sarah-witt sarah-witt marked this pull request as ready for review March 17, 2022 18:33
@sarah-witt sarah-witt requested review from a team as code owners March 17, 2022 18:33
cswatt
cswatt previously approved these changes Mar 17, 2022
@sarah-witt sarah-witt merged commit fa9492b into master Mar 18, 2022
@sarah-witt sarah-witt deleted the sarah/metrics-pattern-docs branch March 18, 2022 18:49
fanny-jiang pushed a commit that referenced this pull request Mar 18, 2022
…st of regexes (#11695)

* Add and sync models

* revert ddev change

* Bump dep

* Update base version

* Revert jmx changes

* Revert jmx version changes, fix formatting

* Fix parsing

* Fix quote

* Update test

* Sync calico

* Remove whitespace
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants