[AGENT-9736] Added debug logs#14650
Merged
vivek-datadog merged 2 commits intomasterfrom Jun 5, 2023
Merged
Conversation
ghost
added
the
vivek-datadog
added
changelog/no-changelog
qa/skip-qa
vivek-datadog
force-pushed
the
vivek/AGENT-9736
branch
from
bd8ffec to
0d6825a
Compare
FlorentClarret
added
changelog/Fixed
and removed
qa/skip-qa
FlorentClarret
approved these changes
May 31, 2023
Member
FlorentClarret
left a comment
FlorentClarret
left a comment
There was a problem hiding this comment.
LGTM
Just changed the label to fixed because this will be shipped with the agent
Codecov Report
Flags with carried forward coverage won't be shown. Click here to find out more. |
iliakur
approved these changes
May 31, 2023
Contributor
julien-lebot
approved these changes
May 31, 2023
- every disk partition check from psutil - excluded disk with size less than configured min disk size Signed-off-by: Vivekanand Ilango <vivekanand.ilango@datadoghq.com>
vivek-datadog
force-pushed
the
vivek/AGENT-9736
branch
from
0d6825a to
50c2451
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Added debug logs
Motivation
While debugging a support request AGENT-9736, the enumerated disks from psutil were not easy to comprehend. Also the disk check gets skipped when the disk size is < minimum configured disk size but the info is logged only when disk size is > 0. To get clarity on this information too a debug log is added.
Additional Notes
Review checklist (to be filled by reviewers)
changelog/andintegration/labels attachedqa/skip-qalabel.