Conversation
Contributor
|
The |
Codecov Report
Flags with carried forward coverage won't be shown. Click here to find out more. |
Contributor
vivek-datadog
approved these changes
Jul 19, 2023
Contributor
vivek-datadog
left a comment
There was a problem hiding this comment.
LGTM, thank you Ofek for the updates 👍
5 tasks
5 tasks
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This upgrades our config model generation to use Pydantic v2
Motivation
Additional Notes
The major change is that now options are nullable and the ones that are not required will be
Noneby default rather than the default value of its type. For example, an optional password field will beNonerather than an empty string if unset.A few other things that are noteworthy about the migration:
= Nonevalidate_default=Trueon theConfigDictobject is what instructs validation to always run even for fields that are unset (allowing us to set defaults), rather than the oldalways=Trueoption on the decoratorsfrozen=Trueon theConfigDictobject is what instructs the model to have best effort immutability, rather than the oldallow_mutation = Falsecheck_rather thanfinalize_Warnings are emitted because of our transformation of mutable types into immutable types. This will be fixed in a subsequent PR.
Review checklist (to be filled by reviewers)
The changes exist only in the base package and in the developer package, the generated code itself is the reason for the large diff