Conversation
Codecov Report
@@ Coverage Diff @@
## master #2483 +/- ##
==========================================
+ Coverage 84.52% 93.54% +9.01%
==========================================
Files 622 11 -611
Lines 35060 558 -34502
Branches 4270 66 -4204
==========================================
- Hits 29636 522 -29114
+ Misses 4137 28 -4109
+ Partials 1287 8 -1279 |
zippolyte
requested changes
Oct 29, 2018
Contributor
zippolyte
left a comment
zippolyte
left a comment
There was a problem hiding this comment.
Great job ! Just a few minor comments
| valid_patterns.append(pattern) | ||
|
|
||
| if valid_patterns: | ||
| return re.compile('|'.join(valid_patterns), casing) |
Contributor
There was a problem hiding this comment.
I think we need to make sure that valid_patterns are enclosed in parenthesis before joining them. Otherwise a pattern containing | could break the matching no ?
Contributor
Author
There was a problem hiding this comment.
I don't think so as a|b|c == (a|b)|c, right?
Contributor
There was a problem hiding this comment.
Yeah I thought I had a example but was mistaken, you're probably right
zippolyte
requested changes
Oct 30, 2018
Contributor
zippolyte
left a comment
zippolyte
left a comment
There was a problem hiding this comment.
Just a few more function names comments and it will be 👌
zippolyte
approved these changes
Oct 30, 2018
Contributor
zippolyte
left a comment
zippolyte
left a comment
There was a problem hiding this comment.
Thanks, looks good now 💯
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds new partition filtering options
file_system_whitelistfile_system_blacklistdevice_whitelistdevice_blacklistmount_point_whitelistmount_point_blacklistAnd began deprecation of
excluded_filesystemsexcluded_disksexcluded_disk_reexcluded_mountpoint_reMotivation
Additional Notes
Also converted config to new style