Skip to content

Add disk label#3953

Merged
coignetp merged 11 commits intomasterfrom
paul/disk-label
Jun 26, 2019
Merged

Add disk label#3953
coignetp merged 11 commits intomasterfrom
paul/disk-label

Conversation

@coignetp
Copy link
Copy Markdown
Contributor

What does this PR do?

Automatically add disk label as a tag

Motivation

Internal request

Additional Notes

Review checklist (to be filled by reviewers)

  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached
  • Feature or bugfix must have tests
  • Git history must be clean
  • If PR adds a configuration option, it must be added to the configuration file.

Copy link
Copy Markdown
Member

@AlexandreYang AlexandreYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just few minor comments.

Comment thread disk/datadog_checks/disk/disk.py Outdated
Comment thread disk/datadog_checks/disk/disk.py Outdated
Comment thread disk/datadog_checks/disk/disk.py Outdated
Comment thread disk/datadog_checks/disk/disk.py Outdated
@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 21, 2019

Codecov Report

Merging #3953 into master will decrease coverage by 9.77%.
The diff coverage is 73.33%.

@@            Coverage Diff             @@
##           master    #3953      +/-   ##
==========================================
- Coverage   86.98%   77.21%   -9.78%     
==========================================
  Files         732       11     -721     
  Lines       37657      610   -37047     
  Branches     4375       80    -4295     
==========================================
- Hits        32757      471   -32286     
+ Misses       3755      122    -3633     
+ Partials     1145       17    -1128

@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 21, 2019

Codecov Report

Merging #3953 into master will increase coverage by 5.69%.
The diff coverage is 89.47%.

@@            Coverage Diff             @@
##           master    #3953      +/-   ##
==========================================
+ Coverage   86.82%   92.52%   +5.69%     
==========================================
  Files         742       11     -731     
  Lines       38102      615   -37487     
  Branches     4395       80    -4315     
==========================================
- Hits        33081      569   -32512     
+ Misses       3888       34    -3854     
+ Partials     1133       12    -1121

Comment thread disk/datadog_checks/disk/disk.py Outdated
Copy link
Copy Markdown
Member

@AlexandreYang AlexandreYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A suggestion about the parsing logic, mostly to avoid low level split/strip

Comment thread disk/datadog_checks/disk/disk.py Outdated
@coignetp coignetp merged commit 0ab20ab into master Jun 26, 2019
@coignetp coignetp deleted the paul/disk-label branch June 26, 2019 13:41
@ofek ofek mentioned this pull request Jul 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants