Conversation
Member
AlexandreYang
left a comment
There was a problem hiding this comment.
Looks good. Just few minor comments.
Codecov Report
@@ Coverage Diff @@
## master #3953 +/- ##
==========================================
- Coverage 86.98% 77.21% -9.78%
==========================================
Files 732 11 -721
Lines 37657 610 -37047
Branches 4375 80 -4295
==========================================
- Hits 32757 471 -32286
+ Misses 3755 122 -3633
+ Partials 1145 17 -1128 |
Codecov Report
@@ Coverage Diff @@
## master #3953 +/- ##
==========================================
+ Coverage 86.82% 92.52% +5.69%
==========================================
Files 742 11 -731
Lines 38102 615 -37487
Branches 4395 80 -4315
==========================================
- Hits 33081 569 -32512
+ Misses 3888 34 -3854
+ Partials 1133 12 -1121 |
hithwen
reviewed
Jun 21, 2019
Member
AlexandreYang
left a comment
There was a problem hiding this comment.
A suggestion about the parsing logic, mostly to avoid low level split/strip
35ae5f9 to
93920b8
Compare
therve
approved these changes
Jun 26, 2019
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Automatically add disk label as a tag
Motivation
Internal request
Additional Notes
Review checklist (to be filled by reviewers)
changelog/andintegration/labels attached