Skip to content

Add disk timeout configuration option#6826

Merged
mx-psi merged 4 commits intomasterfrom
mx-psi/disk-timeout
Jun 9, 2020
Merged

Add disk timeout configuration option#6826
mx-psi merged 4 commits intomasterfrom
mx-psi/disk-timeout

Conversation

@mx-psi
Copy link
Copy Markdown
Member

@mx-psi mx-psi commented Jun 5, 2020

What does this PR do?

  • Add disk timeout configuration option to allow users to customize it for slow disks.
  • Rewrite warning to hint at the new configuration option

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached

@mx-psi mx-psi requested review from a team as code owners June 5, 2020 09:30
@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 5, 2020 •
edited
Loading

Codecov Report

Merging #6826 into master will increase coverage by 6.26%.
The diff coverage is 97.36%.

Impacted Files Coverage Δ
disk/datadog_checks/disk/disk.py 87.25% <75.00%> (+0.85%) ⬆️
disk/tests/test_unit.py 100.00% <100.00%> (ø)
kafka/datadog_checks/kafka/__about__.py
fluentd/tests/util.py
cockroachdb/datadog_checks/cockroachdb/metrics.py
...tras/datadog_checks/linux_proc_extras/__about__.py
..._checks/kube_metrics_server/kube_metrics_server.py
http_check/tests/test_unit_utils.py
...cks_base/datadog_checks/base/utils/db/transform.py
consul/tests/test_unit.py
... and 820 more

AlexandreYang
AlexandreYang previously approved these changes Jun 5, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@AlexandreYang AlexandreYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Just a nice to have feedback.

Comment thread disk/datadog_checks/disk/disk.py
hithwen
hithwen previously approved these changes Jun 5, 2020
View reviewed changes
@mx-psi
Add tests for timeout
46ec318 
* test_timeout_value which checks that every timeout call is done
  with the configuration value
* test_timeout_warning which checks that a warning is raised when
  the timeout raises an exception
@mx-psi mx-psi requested a review from AlexandreYang June 8, 2020 09:23
albertvaka
albertvaka previously approved these changes Jun 8, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@albertvaka albertvaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Nice test as well :)

AlexandreYang
AlexandreYang reviewed Jun 9, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@AlexandreYang AlexandreYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thx for the test 👍

Just a small comment about logging.

Comment thread disk/datadog_checks/disk/disk.py Outdated
@mx-psi mx-psi merged commit d73fca0 into master Jun 9, 2020
@mx-psi mx-psi deleted the mx-psi/disk-timeout branch June 9, 2020 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AlexandreYang AlexandreYang AlexandreYang left review comments

@hithwen hithwen hithwen left review comments

+1 more reviewer

@albertvaka albertvaka albertvaka approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

documentation integration/disk

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mx-psi @hithwen @albertvaka @AlexandreYang
⚡