Add device_label tag in addition to label tag.#8306
Merged
Conversation
This makes labels a bit more consistent with agent's builtin io check, which uses device_label.
FlorianVeaux
approved these changes
Jan 7, 2021
albertvaka
approved these changes
Jan 7, 2021
Author
|
Thanks for the reviews! Merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This makes labels a bit more consistent with agent's builtin
iocheck, which uses device_label. When this is merged, users will be able to consistently usedevice_labeltag for metrics from both of these checks.Motivation
Additional Notes
Review checklist (to be filled by reviewers)
changelog/andintegration/labels attached