Associate label sets with wall profiles#105

Merged

nsavoire merged 27 commits intomainfrom

nsavoire/use_timestamps

Jun 28, 2023

Commits on Jun 26, 2023

Use timestamps to implement code hotspots
nsavoire
committed
typo
nsavoire
committed
Initial code for code hotspots in wall profiler

szegedi
authored and
nsavoire
committed
Maintain profilers per isolate, in a copy-on-write style map

szegedi
authored and
nsavoire
committed
Make labelSetsByNode per-profiler

szegedi
authored and
nsavoire
committed
add labelsCaptured property that can be used to detect profiling sample with labels was taken

szegedi
authored and
nsavoire
committed
Linting

szegedi
authored and
nsavoire
committed
Disable signal code on Windows

szegedi
authored and
nsavoire
committed
Don't use LabelWrap

szegedi
authored and
nsavoire
committed
Leave comments for performance improvements

szegedi
authored and
nsavoire
committed
Encapsulate profile translation, this fixes scoping of labelSetsByNode as well

szegedi
authored and
nsavoire
committed
Optimize creation of reused strings etc.

szegedi
authored and
nsavoire
committed
No need for unsetLabels

szegedi
authored and
nsavoire
committed
Improve RingBuffer and SampleContext move semantics

szegedi
authored and
nsavoire
committed
Restore backwards compatibility of the start method

szegedi
authored and
nsavoire
committed
Hide new functionality behind a flag

szegedi
authored and
nsavoire
committed
Add a test + fixes for the test

szegedi
authored and
nsavoire
committed
Suggestions from Nicolas' review, minus the atomic update of profilers map

szegedi
authored and
nsavoire
committed
Safe atomics for profiler map

szegedi
authored and
nsavoire
committed
unsigneds are evil

szegedi
authored and
nsavoire
committed
Avoid the need for clock sync by ensuring we use the same clock as V8 does

szegedi
authored and
nsavoire
committed
Use time intervals for matching sample contexts

szegedi
authored and
nsavoire
committed
Remove CPU profiler tests. CpuProfiler causes crashes in tests, WONTFIX.

szegedi
authored and
nsavoire
committed
Remove labelsCaptured logic

szegedi
authored and
nsavoire
committed
Ensure atomic updates to labels for signal safety

szegedi
authored and
nsavoire
committed
Don't use RingBuffer.push_front

szegedi
authored and
nsavoire
committed

Commits on Jun 28, 2023

Make code signal safe, fix some minor issues
nsavoire
committed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Associate label sets with wall profiles#105

Associate label sets with wall profiles#105
nsavoire merged 27 commits intomainfrom
nsavoire/use_timestamps

Commits on Jun 26, 2023

Use timestamps to implement code hotspots

typo

Initial code for code hotspots in wall profiler

Maintain profilers per isolate, in a copy-on-write style map

Make labelSetsByNode per-profiler

add labelsCaptured property that can be used to detect profiling sample with labels was taken

Linting

Disable signal code on Windows

Don't use LabelWrap

Leave comments for performance improvements

Encapsulate profile translation, this fixes scoping of labelSetsByNode as well

Optimize creation of reused strings etc.

No need for unsetLabels

Improve RingBuffer and SampleContext move semantics

Restore backwards compatibility of the start method

Hide new functionality behind a flag

Add a test + fixes for the test

Suggestions from Nicolas' review, minus the atomic update of profilers map

Safe atomics for profiler map

unsigneds are evil

Avoid the need for clock sync by ensuring we use the same clock as V8 does

Use time intervals for matching sample contexts

Remove CPU profiler tests. CpuProfiler causes crashes in tests, WONTFIX.

Remove labelsCaptured logic

Ensure atomic updates to labels for signal safety

Don't use RingBuffer.push_front

Commits on Jun 28, 2023

Make code signal safe, fix some minor issues