Skip to content

Add parameters to ceph integration#322

Merged
truthbk merged 1 commit intoDataDog:masterfrom
stamak:ceph_params
May 5, 2017
Merged

Add parameters to ceph integration#322
truthbk merged 1 commit intoDataDog:masterfrom
stamak:ceph_params

Conversation

@stamak
Copy link
Copy Markdown
Contributor

@stamak stamak commented Apr 11, 2017

Closes: #321

# }
#
class datadog_agent::integrations::ceph(
$tags = [ 'name:ceph_cluster' ],
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ugh... I kind of hate that we have to do it this way, but it is indeed the only way to keep backward compatibility 👍

Comment thread templates/agent-conf.d/ceph.yaml.erb Outdated
<% end -%>

ceph_cmd: /usr/bin/ceph
ceph_cmd: <%= @crm_mon_cmd %>
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll have to take a better look, but is this right @crm_mon_cmd?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's mistake, thanks

@truthbk
Copy link
Copy Markdown
Member

truthbk commented Apr 19, 2017

Hi @stamak!

Thanks a lot for your work! Would it be at all possible for you to write a couple spec tests to cover the new usage scenarios? It would help us keep track for future breakage.

Also, there was an issue breaking the CI. Could you please rebase to the latest master? After bringing in the latest stuff to your fork:

git checkout master
git pull
git checkout ceph_params
git rebase master
git push -f origin ceph_params

That should do it. Thank you again for your work and time 🙇

@stamak
Copy link
Copy Markdown
Contributor Author

stamak commented Apr 23, 2017

@truthbk done ;)

@truthbk
Copy link
Copy Markdown
Member

truthbk commented May 5, 2017

Thank you @stamak, this looks good! Merging it in! 🙇

@truthbk truthbk merged commit aae4cf8 into DataDog:master May 5, 2017
cegeka-jenkins pushed a commit to cegeka/puppet-datadog_agent that referenced this pull request Jan 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants