Add parameters to ceph integration#322
Conversation
| # } | ||
| # | ||
| class datadog_agent::integrations::ceph( | ||
| $tags = [ 'name:ceph_cluster' ], |
There was a problem hiding this comment.
Ugh... I kind of hate that we have to do it this way, but it is indeed the only way to keep backward compatibility 👍
| <% end -%> | ||
|
|
||
| ceph_cmd: /usr/bin/ceph | ||
| ceph_cmd: <%= @crm_mon_cmd %> |
There was a problem hiding this comment.
I'll have to take a better look, but is this right @crm_mon_cmd?
There was a problem hiding this comment.
it's mistake, thanks
|
Hi @stamak! Thanks a lot for your work! Would it be at all possible for you to write a couple spec tests to cover the new usage scenarios? It would help us keep track for future breakage. Also, there was an issue breaking the CI. Could you please rebase to the latest That should do it. Thank you again for your work and time 🙇 |
|
@truthbk done ;) |
|
Thank you @stamak, this looks good! Merging it in! 🙇 |
Closes: #321