Addressing metaparam override in datadog_agent::tag#338
Merged
truthbk merged 2 commits intoDataDog:masterfrom Jul 20, 2017
craigwatson:bugfix/tag_metaparam
Merged
Addressing metaparam override in datadog_agent::tag#338truthbk merged 2 commits intoDataDog:masterfrom craigwatson:bugfix/tag_metaparam
truthbk merged 2 commits intoDataDog:masterfrom
craigwatson:bugfix/tag_metaparam
Conversation
Member
|
Thanks @craigwatson 🙇 - taking a look at what happened in the CI. |
Member
|
@craigwatson fixed the TravisCI issue on |
Contributor
Author
|
@truthbk thanks, have now rebased :) |
truthbk
approved these changes
Jul 20, 2017
Member
truthbk
left a comment
truthbk
left a comment
There was a problem hiding this comment.
Despite the parameter name change, this is not a breaking change as the previous behavior was actually overriding the meta parameter - this now actually does what it was meant. Thanks @craigwatson
cegeka-jenkins
pushed a commit
to cegeka/puppet-datadog_agent
that referenced
this pull request
Jan 31, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.